From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Noah Goldstein <goldstein.w.n@gmail.com>,
"H.J. Lu" <hjl.tools@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH 0/5] Use generic sinf, cosf, and sincosf for i686
Date: Wed, 1 Jun 2022 10:12:51 -0300 [thread overview]
Message-ID: <48020b6f-2b34-b7aa-9816-ad02e5043d64@linaro.org> (raw)
In-Reply-To: <164be32d-5f4e-8b43-7d11-4dce01798bcb@linaro.org>
On 01/06/2022 09:36, Adhemerval Zanella wrote:
>
>
> On 31/05/2022 18:53, Noah Goldstein wrote:
>> On Tue, May 31, 2022 at 4:50 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>>>
>>> On Tue, May 31, 2022 at 2:48 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>>>>
>>>> On Tue, May 31, 2022 at 4:35 PM Adhemerval Zanella via Libc-alpha
>>>> <libc-alpha@sourceware.org> wrote:
>>>>>
>>>>> Performance seems to be similar, with generic implementation showing
>>>>> slight better performance for sinf large inputs and for sincosf.
>>>>>
>>>>> Although generic implementation shows slight lower precision (the
>>>>> ulp data required some adjustments), the code size shows a good
>>>>> improvement:
>>>>>
>>>>
>>>> How much loss of precision?
>>>
>>> About 1ULP.
>>
>> Should be okay then. Does:
>> https://www.gnu.org/software/libc/manual/html_node/Errors-in-Math-Functions.html
>> need to be updated?
>
> Good call, I will send a patch to update the documentation.
>
In fact the table is already auto-generated from libm-ulps files, so there is
no need to change anything.
next prev parent reply other threads:[~2022-06-01 13:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 21:34 Adhemerval Zanella
2022-05-31 21:34 ` [PATCH 1/5] benchtests: Add workload name for cosf Adhemerval Zanella
2022-05-31 21:47 ` H.J. Lu
2022-05-31 21:34 ` [PATCH 2/5] i686: Use generic cosf implementation for SSE2 version Adhemerval Zanella
2022-05-31 21:46 ` H.J. Lu
2022-05-31 21:35 ` [PATCH 3/5] i686: Use generic sinf " Adhemerval Zanella
2022-05-31 21:47 ` H.J. Lu
2022-05-31 21:35 ` [PATCH 4/5] benchtests: Add workload name for sincosf Adhemerval Zanella
2022-05-31 21:48 ` H.J. Lu
2022-05-31 21:35 ` [PATCH 5/5] math: Use generic sinf implementation for SSE2 version Adhemerval Zanella
2022-05-31 21:51 ` H.J. Lu
2022-06-01 12:42 ` Adhemerval Zanella
2022-06-01 15:14 ` H.J. Lu
2022-06-01 16:06 ` Adhemerval Zanella
2022-05-31 21:48 ` [PATCH 0/5] Use generic sinf, cosf, and sincosf for i686 Noah Goldstein
2022-05-31 21:49 ` H.J. Lu
2022-05-31 21:53 ` Noah Goldstein
2022-06-01 12:36 ` Adhemerval Zanella
2022-06-01 13:12 ` Adhemerval Zanella [this message]
2022-06-01 16:23 Wilco Dijkstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48020b6f-2b34-b7aa-9816-ad02e5043d64@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=goldstein.w.n@gmail.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).