From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26595 invoked by alias); 6 Oct 2016 12:21:45 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 26580 invoked by uid 89); 6 Oct 2016 12:21:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=uchar_t, UCHAR_T, read_int, preexisting X-HELO: mx1.redhat.com Subject: Re: [PATCH] Use read_int in vfscanf To: "Gabriel F. T. Gomes" , libc-alpha@sourceware.org References: <1474595428-20601-1-git-send-email-gftg@linux.vnet.ibm.com> Cc: joseph@codesourcery.com From: Florian Weimer Message-ID: <482ccd6e-5d17-c87f-2033-030493118f70@redhat.com> Date: Thu, 06 Oct 2016 12:21:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1474595428-20601-1-git-send-email-gftg@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00133.txt.bz2 On 09/23/2016 03:50 AM, Gabriel F. T. Gomes wrote: > + argpos = read_int ((const UCHAR_T **) &f); This is a const char * → const unsigned char * cast in the non-wide case (and okay), but in the wide case, it goes from const int * to const unsigned int *, which is not valid. This is a pre-existing issue in vfprintf.c, so I don't think it should block inclusion of this cleanup. Florian