From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa2f.google.com (mail-vk1-xa2f.google.com [IPv6:2607:f8b0:4864:20::a2f]) by sourceware.org (Postfix) with ESMTPS id 345CA385801B for ; Tue, 30 Nov 2021 14:53:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 345CA385801B Received: by mail-vk1-xa2f.google.com with SMTP id m16so12777506vkl.13 for ; Tue, 30 Nov 2021 06:53:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=3WoVAlZxkUUDQBX1CawdRHnelXby5LWaBE1jbVvrb/4=; b=ifxJ6ux0Gm9oW96ycaOR5mGjvlFDPxUpkF9jVCN0scpDrCtX/0M1ie7NFGqIie3xhA U9pZSZpiPl081/FNZLB0CplO+Z+trORBxxmNLX7Zbqe+dowle7yOATJPmKYwvO5V1duV P/45T9jCKzn3nUsitneLmz5RDZWg38tOEtzvOJ549jt92LfxasgZyf+zfIOqztT4L/aR 6YZjdb2m9WAdaTMXDREsgo69gnFYCBTy5Jdeyh5sLRgloYxmXDqK8uy0JowsmYqltkmp qmomF05URw7FTNUU8CTthkekXvvu6OXgbn/vkC2Js1VvMojS6juRxEAtO895k6XMnce8 XkEQ== X-Gm-Message-State: AOAM532D2FO5/N5N1Qp2VwYb8r85QVjf94FISNBnU7+o9/Z6a2UwEX3U 45ijDapkGyehPiCCHZg+73mpzw== X-Google-Smtp-Source: ABdhPJxk73akXLLGo10ivz9gd2P//uPMfGLeQOd7FySTWK4xEcInyB0X6OGpVdaZymHOZBF7tyib3w== X-Received: by 2002:a1f:c9c2:: with SMTP id z185mr43723559vkf.26.1638283995091; Tue, 30 Nov 2021 06:53:15 -0800 (PST) Received: from ?IPV6:2804:431:c7cb:30f8:6601:a360:bcd5:8568? ([2804:431:c7cb:30f8:6601:a360:bcd5:8568]) by smtp.gmail.com with ESMTPSA id b13sm10345647vkn.38.2021.11.30.06.53.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Nov 2021 06:53:14 -0800 (PST) Message-ID: <483f3659-7a9c-4732-3edd-993ef2e34b28@linaro.org> Date: Tue, 30 Nov 2021 11:53:12 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH 4/6] linux: Implement pipe in terms of __NR_pipe2 Content-Language: en-US To: Stafford Horne Cc: libc-alpha@sourceware.org References: <20211122185437.1934590-1-adhemerval.zanella@linaro.org> <20211122185437.1934590-5-adhemerval.zanella@linaro.org> From: Adhemerval Zanella In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Nov 2021 14:53:17 -0000 On 26/11/2021 20:03, Stafford Horne wrote: > On Mon, Nov 22, 2021 at 03:54:35PM -0300, Adhemerval Zanella wrote: >> It removes the arch-specific implementation for alpha, ia64, >> mips, sh, and sparc which requires a different kernel ABI >> than the usual one. >> >> Checked on x86_64-linux-gnu and with a build for the affected ABIs. >> --- >> sysdeps/unix/alpha/pipe.S | 30 -------------- >> sysdeps/unix/mips/pipe.S | 31 --------------- >> sysdeps/unix/sysv/linux/alpha/pipe.S | 1 - >> sysdeps/unix/sysv/linux/ia64/pipe.S | 36 ----------------- >> sysdeps/unix/sysv/linux/mips/pipe.S | 1 - >> sysdeps/unix/sysv/linux/{generic => }/pipe.c | 5 ++- >> sysdeps/unix/sysv/linux/sh/pipe.S | 42 -------------------- >> sysdeps/unix/sysv/linux/sparc/sparc32/pipe.S | 38 ------------------ >> sysdeps/unix/sysv/linux/sparc/sparc64/pipe.S | 39 ------------------ >> sysdeps/unix/sysv/linux/syscalls.list | 1 - >> 10 files changed, 3 insertions(+), 221 deletions(-) >> delete mode 100644 sysdeps/unix/alpha/pipe.S >> delete mode 100644 sysdeps/unix/mips/pipe.S >> delete mode 100644 sysdeps/unix/sysv/linux/alpha/pipe.S >> delete mode 100644 sysdeps/unix/sysv/linux/ia64/pipe.S >> delete mode 100644 sysdeps/unix/sysv/linux/mips/pipe.S >> rename sysdeps/unix/sysv/linux/{generic => }/pipe.c (87%) >> delete mode 100644 sysdeps/unix/sysv/linux/sh/pipe.S >> delete mode 100644 sysdeps/unix/sysv/linux/sparc/sparc32/pipe.S >> delete mode 100644 sysdeps/unix/sysv/linux/sparc/sparc64/pipe.S > > This patch all looks good to me. > > We might want to mention in the commit message that this is allowed because: > > The syscall pipe2 was added in linux 2.6.27 and glibc requires linux 3.2.0. Ack. > > For reference, these patches set the tree wided minimum required version most > recently. I dont know what it was before but its fare to say using pipe2 is > safe. > > 2016: 5b4ecd3f95 ("Require Linux 3.2 except on x86 / x86_64, 3.2 headers everywhere."). > 2017: 139ace9575 ("Require Linux kernel 3.2 or later on x86 / x86_64."). > > -Stafford >