From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) by sourceware.org (Postfix) with ESMTPS id DD88C3858407 for ; Fri, 17 Dec 2021 16:39:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DD88C3858407 Received: by mail-qk1-x72e.google.com with SMTP id d21so2692299qkl.3 for ; Fri, 17 Dec 2021 08:39:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=w3F2ADM2dz53AIy0hcTtKV2ecFfnw1owYNWZedxyV+M=; b=6yJrpSXf70bM+0vCB4ho1ybpcKyhJD/gZaYe5EfwualR8x277OtPFm6xs9ZQX/r+Nh UZ9Xcz4wvr82klKBz8p64I4xISY9RfzvAvBnQY167F9p6MoXlnIgBFidmiR4y8kormnz uNGpeRygHn/JT3mX4MUpWJRlkc7WGOw1qsCzbNhk2SVboLQEu5dw1n5L7kzT0BhcisUI //4qGRROm2GuUfVQYKqJ6c/n22Mp7LKgw+Lp+k4SEN/hK26CXuzCWOUNUbwgacvaxXi6 v3nh+pvCDl0gmAriJ635cTihAEusNXe1gfnAocYOcv0HSkC/W5FbL8xefPwu++1A/2we cGEQ== X-Gm-Message-State: AOAM5311Me6vrMDN5EqJxX/AuD6PfzBvHg+GazeldksOzhfNbQUWvsoG c+BmC6muIeG1JMzyeJ4iPSzAEA== X-Google-Smtp-Source: ABdhPJzul7O32KSBrWUNukGWvxCQUtiOZYVTSHttRaOhvxXZxG0LgUDjbwneaYyFLJ6cMdAphepr4A== X-Received: by 2002:a05:620a:c52:: with SMTP id u18mr2370060qki.203.1639759190465; Fri, 17 Dec 2021 08:39:50 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:103f:7084:332e:7513:f115? ([2804:431:c7ca:103f:7084:332e:7513:f115]) by smtp.gmail.com with ESMTPSA id j20sm5167260qko.117.2021.12.17.08.39.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Dec 2021 08:39:50 -0800 (PST) Message-ID: <489b7cb8-5e05-0659-a7f8-84d164d84fe1@linaro.org> Date: Fri, 17 Dec 2021 13:39:47 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v6 05/20] elf: Add _dl_audit_objclose Content-Language: en-US To: Florian Weimer Cc: libc-alpha@sourceware.org, John Mellor-Crummey , Ben Woodard References: <20211115183734.531155-1-adhemerval.zanella@linaro.org> <20211115183734.531155-6-adhemerval.zanella@linaro.org> <87pmpvi49x.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <87pmpvi49x.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Dec 2021 16:39:52 -0000 On 17/12/2021 13:29, Florian Weimer wrote: > * Adhemerval Zanella: > >> diff --git a/elf/dl-audit.c b/elf/dl-audit.c >> index de85ef1ddd..ef34ff761c 100644 >> --- a/elf/dl-audit.c >> +++ b/elf/dl-audit.c >> @@ -99,4 +99,25 @@ _dl_audit_objopen (struct link_map *l, Lmid_t nsid, bool check_audit) >> afct = afct->next; >> } >> } >> + >> +void >> +_dl_audit_objclose (struct link_map *l, Lmid_t nsid) > > The nsid argument is unused, l->l_ns is used instead. Rest looks good. Ack.