From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by sourceware.org (Postfix) with ESMTPS id C7E053858CDB for ; Fri, 26 May 2023 14:25:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C7E053858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oi1-x22a.google.com with SMTP id 5614622812f47-397f3aec11aso673017b6e.1 for ; Fri, 26 May 2023 07:25:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685111112; x=1687703112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=gU15OaXYPo7TkMo4+uce3iSFuyHKVsNvGcU3HziNnfk=; b=Sme4kMPtc+SLHIvrOeROnD++JXqdbBpOGAks3B3JjWcAE4S8mK4H2Ot+tbongKDwXl nvx+ATNOYHgOXhcGI7JEYMxNTaGlL3S6phyoOPubD/NsKXj6Gsl0lkbQEVYc3h+tDQyH qAjkVzidRcTv+cbZvxRMCN6M6UhGfdKWU5Y9aHeuNG/Km9KR9q+QXSPa8kRE2YOfEWq5 PsmfCHZtnKN6xZCqdeNB95X9BIuKSc5jBtBRjvsvw3MHQCnLlpsxlTh8fJc8qNuroYpR FtOcVet3UgrnEHtxTJxME9Sr7XAfDVPv7g7nE0XsJhBD+q1xuSBwmiprvZCv03lfXRFT rZzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685111112; x=1687703112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gU15OaXYPo7TkMo4+uce3iSFuyHKVsNvGcU3HziNnfk=; b=QEeV/e2EB/YCVUlfinaI73hKborqPOcqbYk5rylE2uiMb/Xt+EAxgtqI0VmLChbYyh 9T3Hd8l4gbT6MCTOybTdD5KjPSDuH2L5mIT7GBQPYsXhol+M1LJ87aJghfLf6sTYVMVl 19I5WDqmLUu+U0Oy4CtYdsy2PtJd4JH5RIVwnv65qfbi7BXWlEoPdNEL2gfv5JLCtbwX 2DYM/0wWIPMnn2vPsNiyYclIFVTZ7ZKhMi/OJJfuzGQE5QTPN6XInCt5SkwghNwMec3+ vOc0ppvs0OTUo5p01QFzCgR2Yl2KjviUqmFYFPdjUdfa1GckxQqTUKqzxri3KsBjYj94 3qiw== X-Gm-Message-State: AC+VfDw4QN8+LWHU8f9aCVdqntiGSt15swxkA12li9sxGkM2X91+8HDS tK92lgfxGpepo5f9cL2+oqnx7E52YvJuYJWhpHBhhA== X-Google-Smtp-Source: ACHHUZ73PlbG8fVVI8z93Q7IBZ2dE1oCXcCtmZNHjkR+LUgv6wro4cBKjSJHHvRO65q6vcPhkSUPaA== X-Received: by 2002:aca:e083:0:b0:394:5c96:120f with SMTP id x125-20020acae083000000b003945c96120fmr1882763oig.22.1685111112068; Fri, 26 May 2023 07:25:12 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c1:4dd5:80c6:51f7:4cf7:20d3? ([2804:1b3:a7c1:4dd5:80c6:51f7:4cf7:20d3]) by smtp.gmail.com with ESMTPSA id t8-20020a0568301e2800b006ab241d8c42sm1750139otr.17.2023.05.26.07.25.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 May 2023 07:25:11 -0700 (PDT) Message-ID: <48a839f7-6eb4-88f8-e559-4c625577812b@linaro.org> Date: Fri, 26 May 2023 11:25:09 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.1 Subject: Re: [PATCH 1/2] fnmatch: allow character class names with 'z' Content-Language: en-US To: Carlo Arenas Cc: libc-alpha@sourceware.org References: <20230523073732.6956-1-carenas@gmail.com> <20230523073732.6956-2-carenas@gmail.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 23/05/23 18:55, Carlo Arenas wrote: > On Tue, May 23, 2023 at 11:09 AM Adhemerval Zanella Netto > wrote: >> . Also, current practice is to both add >> a bug report if this is a user-visible issue (which seems so) along with >> a testcase to avoid any potential regression. Cold you provide both? > > Sure; but I would like to clarify that the bug I was really targeting > has a bugzilla[1] entry already and the fix[2] for it includes "part > 2" of a fix for this. Thanks, we are now enforcing regression tests on every bug report. Since it already have a reproducer, just follow other fnmatch tests (for instance posix/tst-fnmatch7.c). > > My assumption was that this bug is too old and has no user effect > (unless someone adds a custom class name with 'z' in their name), and > in the 20 years that had gone by, there are only a handful of those. > > Either way, I will be adding tests for both bugs in a v2, but wanted > to be sure you would have them split (which I would normally agree > with), or maybe I should have squashed both commits instead. I would say to just squash them on same patch. > > Carlo > > [1] https://sourceware.org/bugzilla/show_bug.cgi?id=30483 > [2] https://patchwork.sourceware.org/project/glibc/patch/20230523073732.6956-3-carenas@gmail.com/