From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from earwig.ash.relay.mailchannels.net (earwig.ash.relay.mailchannels.net [23.83.222.54]) by sourceware.org (Postfix) with ESMTPS id 1F48D3858435 for ; Fri, 21 Jan 2022 18:02:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1F48D3858435 X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 6040D882168; Fri, 21 Jan 2022 18:02:14 +0000 (UTC) Received: from pdx1-sub0-mail-a306.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 1774C881E8E; Fri, 21 Jan 2022 18:02:14 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a306.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.124.31.106 (trex/6.4.3); Fri, 21 Jan 2022 18:02:14 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Gusty-Name: 6abb7e246ae2c622_1642788134288_3268647441 X-MC-Loop-Signature: 1642788134288:3900998244 X-MC-Ingress-Time: 1642788134288 Received: from [192.168.1.174] (unknown [1.186.224.214]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a306.dreamhost.com (Postfix) with ESMTPSA id 4JgRzS16ktz13; Fri, 21 Jan 2022 10:02:11 -0800 (PST) Message-ID: <48f33379-ee6d-ff99-b051-a8739dd6db84@sourceware.org> Date: Fri, 21 Jan 2022 23:32:06 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v4] getcwd: Set errno to ERANGE for size == 1 (CVE-2021-3999) Content-Language: en-US To: Andreas Schwab , Siddhesh Poyarekar via Libc-alpha Cc: Qualys Security Advisory References: <20220121173831.2185053-1-siddhesh@sourceware.org> <87r191c6m0.fsf@igel.home> From: Siddhesh Poyarekar In-Reply-To: <87r191c6m0.fsf@igel.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3486.3 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Jan 2022 18:02:20 -0000 On 21/01/2022 23:29, Andreas Schwab wrote: > On Jan 21 2022, Siddhesh Poyarekar via Libc-alpha wrote: > >> +static int >> +recv_fd (const int sock) >> +{ >> + struct msghdr msg; >> + union >> + { >> + struct cmsghdr hdr; >> + char buf[CMSG_SPACE(sizeof(int))]; >> + } cmsgbuf; > > Zero-init like in send_fd. > Thanks, I missed that. Sending v5. Siddhesh