From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by sourceware.org (Postfix) with ESMTPS id 296223858439 for ; Mon, 20 Feb 2023 19:27:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 296223858439 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-pg1-x530.google.com with SMTP id z10so1091114pgr.8 for ; Mon, 20 Feb 2023 11:27:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oJ7W41OpEmHRGRTechZS8vXsJA9RWqCVmnXgZx5lQwo=; b=OQskiYBKlN//LDqvDswvVkLScCDBsioysCwh69GeM6X9DO9yTni72VEF0xP5Kl247F zKq+lqg41tjRvRjWWPnNggS1eFcHA5mWeUK4D8xB/TFDvMmBLhdJK1tn7LNvvvKNEyNo nKoS737n1iYynyNpeON1+z2VHf6Nz0dwsUnCcbTvDS4KWyVc9xAzdmStmX/PcLVNMv9a eqNj5dEE2MSXBJH7Pgm8jBxCMoH+MhkW5VF5a8mgkubLkJ8x/CVg/s0Y2tJryl9xbZoO 4Fbf9XcpJtWvZcGDgP4+f+2GnQERDMGnuGazefl47kSVsORTQ9Opra95rmygE/xo5YiH xpXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oJ7W41OpEmHRGRTechZS8vXsJA9RWqCVmnXgZx5lQwo=; b=KoNdZWgYm0uiXbjQ3pvpZn5jg2ewZNo+SXO5lEGsOVgbujAHKC72QlFQEWBRe3YVpu nUkNQhzBriJkgeXR0DSHn+DjwsFrpjUEjvoZ697OgST9qWb3nrV5OWL4EhIup3F6anSo GC7E+m4kTSvxGtJAA3/KiCh+/Dvqc0ybP5XXwI/MBnT0e/526y8cA8JR4DaZ9JYdCuMp 0iNuFjDHUNvA+vvRMBbNIGCBhm9yGNgzh6eBaRYAeFgWdnUp9uRWL/vMegiNiGfj8uS5 OE86OGoZsfGd7uUgGOE7IEaOwIypVwNeN/mbHglseRe9eMRj4p9feVP/bf7eMPLEFPmC 7vRA== X-Gm-Message-State: AO0yUKVAKaRbkPO9Leci1e3G5no2NsNnAkj5UfCk6/Nj30yninnRVw8S tzUV7dCBDqOrax8QNn6ac+J7cqmfP9Gt5DAUffQ= X-Google-Smtp-Source: AK7set/yHhxDir7tFmHGZc/d4VTSPGDw3IhGOfAH8ebgsA9qrtrgjeeYGjtZNgm1HeIql//X6efEDA== X-Received: by 2002:a62:61c5:0:b0:5a9:c4d6:bfa6 with SMTP id v188-20020a6261c5000000b005a9c4d6bfa6mr733109pfb.6.1676921221145; Mon, 20 Feb 2023 11:27:01 -0800 (PST) Received: from [192.168.6.128] (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id w2-20020aa78582000000b005a8cc32b23csm6819204pfn.20.2023.02.20.11.26.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Feb 2023 11:27:00 -0800 (PST) Message-ID: <48f954b7-2ba5-ddb2-cb73-323029b0ed82@linaro.org> Date: Mon, 20 Feb 2023 09:26:57 -1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] arm: Support gcc older than 10 for find_zero_all Content-Language: en-US To: Adhemerval Zanella , libc-alpha@sourceware.org, Szabolcs Nagy References: <20230220164809.2581181-1-adhemerval.zanella@linaro.org> From: Richard Henderson In-Reply-To: <20230220164809.2581181-1-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/20/23 06:48, Adhemerval Zanella via Libc-alpha wrote: > __builtin_arm_uqsub8 is only available on gcc newer or equal than 10. > > Checked on arm-linux-gnueabihf built with gcc 9. > --- > sysdeps/arm/armv6t2/string-fza.h | 6 ++++++ > 1 file changed, 6 insertions(+) Whoops, thanks. Reviewed-by: Richard Henderson > > diff --git a/sysdeps/arm/armv6t2/string-fza.h b/sysdeps/arm/armv6t2/string-fza.h > index 76274ccca7..d85ce86434 100644 > --- a/sysdeps/arm/armv6t2/string-fza.h > +++ b/sysdeps/arm/armv6t2/string-fza.h > @@ -33,7 +33,13 @@ find_zero_all (op_t x) > /* Use unsigned saturated subtraction from 1 in each byte. > That leaves 1 for every byte that was zero. */ > op_t ones = repeat_bytes (0x01); > +#if __GNUC_PREREQ (10, 0) > return __builtin_arm_uqsub8 (ones, x); > +#else > + op_t ret; > + asm ("uqsub8 %0,%1,%2" : "=r"(ret) : "r"(ones), "r"(x)); > + return ret; > +#endif > } > > /* Identify bytes that are equal between X1 and X2. */