public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Paul E Murphy <murphyp@linux.ibm.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
	libc-alpha@sourceware.org
Cc: Richard Henderson <rth@twiddle.net>,
	Joseph Myers <joseph@codesourcery.com>,
	caiyinyu <caiyinyu@loongson.cn>
Subject: Re: [PATCH 16/17] powerpc: Add string-fza.h
Date: Tue, 6 Sep 2022 09:48:31 -0500	[thread overview]
Message-ID: <496d9efc-6d13-7391-a70c-4a9b5ff18ed9@linux.ibm.com> (raw)
In-Reply-To: <20220902203940.2385967-17-adhemerval.zanella@linaro.org>



On 9/2/22 3:39 PM, Adhemerval Zanella via Libc-alpha wrote:
> From: Richard Henderson <rth@twiddle.net>
> 
> While ppc has the more important string functions in assembly,
> there are still a few generic routines used.
> 
> Use the Power 6 CMPB insn for testing of zeros.
> 
> Checked on powerpc64le-linux-gnu.
> ---
>   sysdeps/powerpc/string-fza.h | 70 ++++++++++++++++++++++++++++++++++++
>   1 file changed, 70 insertions(+)
>   create mode 100644 sysdeps/powerpc/string-fza.h
> 
> diff --git a/sysdeps/powerpc/string-fza.h b/sysdeps/powerpc/string-fza.h
> new file mode 100644
> index 0000000000..5f7e9c5cbe
> --- /dev/null
> +++ b/sysdeps/powerpc/string-fza.h
> @@ -0,0 +1,70 @@
> +/* Zero byte detection; basics.  PowerPC version.
> +   Copyright (C) 2022 Free Software Foundation, Inc.
> +   This file is part of the GNU C Library.
> +
> +   The GNU C Library is free software; you can redistribute it and/or
> +   modify it under the terms of the GNU Lesser General Public
> +   License as published by the Free Software Foundation; either
> +   version 2.1 of the License, or (at your option) any later version.
> +
> +   The GNU C Library is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +   Lesser General Public License for more details.
> +
> +   You should have received a copy of the GNU Lesser General Public
> +   License along with the GNU C Library; if not, see
> +   <http://www.gnu.org/licenses/>.  */
> +
> +#ifndef POWERPC_STRING_FZA_H
> +#define POWERPC_STRING_FZA_H 1
> +
> +/* PowerISA 2.03 (POWER6) provides cmpb instruction.  */

Should this read "PowerISA 2.05"? cmpb is listed as implemented from 
v2.05 in ISA 3.1.

> +#ifdef _ARCH_PWR6
> +# include <string-optype.h>
> +
> +/* This function returns 0xff for each byte that is
> +   equal between X1 and X2.  */
> +
> +static inline op_t
> +find_eq_all (op_t x1, op_t x2)
> +{
> +  op_t ret;
> +  asm ("cmpb %0,%1,%2" : "=r"(ret) : "r"(x1), "r"(x2));

Is it possible to use the gcc builtin __builtin_cmpb?

Otherwise, LGTM.

> +  return ret;
> +}
> +
> +/* This function returns 0xff for each byte that is zero in X.  */
> +
> +static inline op_t
> +find_zero_all (op_t x)
> +{
> +  return find_eq_all (x, 0);
> +}
> +
> +/* Identify zero bytes in X1 or equality between X1 and X2.  */
> +
> +static inline op_t
> +find_zero_eq_all (op_t x1, op_t x2)
> +{
> +  return find_zero_all (x1) | find_eq_all (x1, x2);
> +}
> +
> +/* Identify zero bytes in X1 or inequality between X1 and X2.  */
> +
> +static inline op_t
> +find_zero_ne_all (op_t x1, op_t x2)
> +{
> +  return find_zero_all (x1) | ~find_eq_all (x1, x2);
> +}
> +
> +/* Define the "inexact" versions in terms of the exact versions.  */
> +# define find_zero_low		find_zero_all
> +# define find_eq_low		find_eq_all
> +# define find_zero_eq_low	find_zero_eq_all
> +# define find_zero_ne_low	find_zero_ne_all
> +#else
> +# include <sysdeps/generic/string-fza.h>
> +#endif /* _ARCH_PWR6  */
> +
> +#endif /* STRING_FZA_H  *

  reply	other threads:[~2022-09-06 14:48 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-02 20:39 [PATCH 00/17] Improve generic string routines Adhemerval Zanella
2022-09-02 20:39 ` [PATCH 01/17] Parameterize op_t from memcopy.h Adhemerval Zanella
2022-09-02 20:39 ` [PATCH 02/17] Parameterize OP_T_THRES " Adhemerval Zanella
2022-09-02 20:39 ` [PATCH 03/17] Add string-maskoff.h generic header Adhemerval Zanella
2022-09-02 20:39 ` [PATCH 04/17] Add string vectorized find and detection functions Adhemerval Zanella
2022-09-03  3:20   ` Noah Goldstein
2022-09-19 14:00     ` Adhemerval Zanella Netto
2022-09-02 20:39 ` [PATCH 05/17] string: Improve generic strlen Adhemerval Zanella
2022-09-02 20:39 ` [PATCH 06/17] string: Improve generic strnlen Adhemerval Zanella
2022-09-02 20:39 ` [PATCH 07/17] string: Improve generic strchr Adhemerval Zanella
2022-09-02 20:39 ` [PATCH 08/17] string: Improve generic strchrnul Adhemerval Zanella
2022-09-02 20:39 ` [PATCH 09/17] string: Improve generic strcmp Adhemerval Zanella
2022-09-03  3:31   ` Noah Goldstein
2022-09-19 14:04     ` Adhemerval Zanella Netto
2022-09-03  8:54   ` Richard Henderson
2022-09-02 20:39 ` [PATCH 10/17] string: Improve generic memchr Adhemerval Zanella
2022-09-03  3:47   ` Noah Goldstein
2022-09-19 19:17     ` Adhemerval Zanella Netto
2022-09-19 21:59       ` Noah Goldstein
2022-09-22 17:51         ` Adhemerval Zanella Netto
2022-09-02 20:39 ` [PATCH 11/17] string: Improve generic memrchr Adhemerval Zanella
2022-09-02 20:39 ` [PATCH 12/17] hppa: Add memcopy.h Adhemerval Zanella
2022-09-02 20:39 ` [PATCH 13/17] hppa: Add string-fzb.h and string-fzi.h Adhemerval Zanella
2022-09-02 20:39 ` [PATCH 14/17] alpha: " Adhemerval Zanella
2022-09-02 20:39 ` [PATCH 15/17] arm: Add string-fza.h Adhemerval Zanella
2022-09-05 15:40   ` Richard Earnshaw
2022-09-05 15:50     ` Richard Earnshaw
2022-09-02 20:39 ` [PATCH 16/17] powerpc: " Adhemerval Zanella
2022-09-06 14:48   ` Paul E Murphy [this message]
2022-09-19 19:55     ` Adhemerval Zanella Netto
2022-09-02 20:39 ` [PATCH 17/17] sh: Add string-fzb.h Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=496d9efc-6d13-7391-a70c-4a9b5ff18ed9@linux.ibm.com \
    --to=murphyp@linux.ibm.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=caiyinyu@loongson.cn \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).