From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by sourceware.org (Postfix) with ESMTPS id 96B873851C18 for ; Wed, 11 Nov 2020 16:21:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 96B873851C18 Received: by mail-qk1-x742.google.com with SMTP id d9so2170733qke.8 for ; Wed, 11 Nov 2020 08:21:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BdBhO1J71XlZghhINJLvkjH2GwF1sjtNYUTixdM9Qvg=; b=JrNNYUQuNAJLvDoKFDmOUznXhtp7he7RXVmXlfZawFoxbAsxx8sQ6wA37m5WDgc//d seno9DJsJ3Pwu8duKrAnBVzi2E7j4PcvpdK6OXn6Fn3LWMqljQt65byJBYMZ9FPQ60Qf Z7d4PlXQEvAWmWdOB66ssdi5LbPyla9tfKYc7DJcfhvMFTn4jh3ObbjT9Rnq2aRmqApu C5tFXcGjvBPp13WMdiDYYYYtGdqXirucft9dLbdV4DRhldzFUkAhOtE7SpxzhDDmexrr UdxxlTtK1qOnBqSzeIDgtUpXw4f5Qg8BHGKtR1E+4dSwKDNWgVimLjMlGn2llmWt/QA3 axsA== X-Gm-Message-State: AOAM531smne9ncoLT6KZ8kOsPvB9UBA7WCOHhxjJ/KvapYWb/RUJLyYK VX6K6AJvrakBH7DLP08eQYvy+Sck0KSz3A== X-Google-Smtp-Source: ABdhPJy4TPTGgoLa+IZ06HnmtMX36oFsUMhuydfXMRCRntqCpwVyNaHX7nfe2Uzv9HFCKVlb9GUC6g== X-Received: by 2002:a37:a086:: with SMTP id j128mr17452533qke.221.1605111701505; Wed, 11 Nov 2020 08:21:41 -0800 (PST) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id w192sm2586535qka.68.2020.11.11.08.21.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Nov 2020 08:21:40 -0800 (PST) Subject: Re: [PATCH 01/23] linux: Remove INTERNAL_SYSCALL_ERRNO To: Florian Weimer , Adhemerval Zanella via Libc-alpha References: <20201109201826.120534-1-adhemerval.zanella@linaro.org> <20201109201826.120534-2-adhemerval.zanella@linaro.org> <878sb9mpox.fsf@oldenburg2.str.redhat.com> From: Adhemerval Zanella Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Message-ID: <498305c2-bbbe-4bfb-e5ef-aa4d539bae56@linaro.org> Date: Wed, 11 Nov 2020 13:21:38 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <878sb9mpox.fsf@oldenburg2.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-14.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Nov 2020 16:21:44 -0000 On 10/11/2020 08:11, Florian Weimer wrote: > * Adhemerval Zanella via Libc-alpha: > >> diff --git a/sysdeps/unix/sysv/linux/posix_fadvise.c b/sysdeps/unix/sysv/linux/posix_fadvise.c >> index bada96b697..1191ab3db5 100644 >> --- a/sysdeps/unix/sysv/linux/posix_fadvise.c >> +++ b/sysdeps/unix/sysv/linux/posix_fadvise.c >> @@ -60,8 +60,6 @@ posix_fadvise (int fd, off_t offset, off_t len, int advise) >> SYSCALL_LL (len), advise); >> # endif >> # endif >> - if (INTERNAL_SYSCALL_ERROR_P (ret)) >> - return INTERNAL_SYSCALL_ERRNO (ret); >> - return 0; >> + return INTERNAL_SYSCALL_ERROR_P (ret) ? -ret : 0; >> } >> #endif /* __OFF_T_MATCHES_OFF64_T */ >> diff --git a/sysdeps/unix/sysv/linux/posix_fadvise64.c b/sysdeps/unix/sysv/linux/posix_fadvise64.c >> index 9787ab4c7c..e3726a6a8a 100644 >> --- a/sysdeps/unix/sysv/linux/posix_fadvise64.c >> +++ b/sysdeps/unix/sysv/linux/posix_fadvise64.c >> @@ -48,9 +48,7 @@ __posix_fadvise64_l64 (int fd, off64_t offset, off64_t len, int advise) >> __ALIGNMENT_ARG SYSCALL_LL64 (offset), >> SYSCALL_LL64 (len), advise); >> #endif >> - if (!INTERNAL_SYSCALL_ERROR_P (ret)) >> - return 0; >> - return INTERNAL_SYSCALL_ERRNO (ret); >> + return INTERNAL_SYSCALL_ERROR_P (ret) ? -ret : 0; >> } >> >> /* The type of the len argument was changed from size_t to off_t in > > These two could just use -ret, I think. The kernel returns 0 for > success, right? > Yes, I make this change on the the subsequent patch where I remove the INTERNAL_SYSCALL_ERROR_P macro. >> diff --git a/sysdeps/unix/sysv/linux/posix_fallocate.c b/sysdeps/unix/sysv/linux/posix_fallocate.c >> index 7238b00038..87532668cd 100644 >> --- a/sysdeps/unix/sysv/linux/posix_fallocate.c >> +++ b/sysdeps/unix/sysv/linux/posix_fallocate.c >> @@ -30,7 +30,7 @@ posix_fallocate (int fd, __off_t offset, __off_t len) >> SYSCALL_LL (offset), SYSCALL_LL (len)); >> if (! INTERNAL_SYSCALL_ERROR_P (res)) >> return 0; >> - if (INTERNAL_SYSCALL_ERRNO (res) != EOPNOTSUPP) >> - return INTERNAL_SYSCALL_ERRNO (res); >> + if (res != -EOPNOTSUPP) >> + return -res; >> return internal_fallocate (fd, offset, len); >> } >> diff --git a/sysdeps/unix/sysv/linux/posix_fallocate64.c b/sysdeps/unix/sysv/linux/posix_fallocate64.c >> index 2de63ac277..0340357e57 100644 >> --- a/sysdeps/unix/sysv/linux/posix_fallocate64.c >> +++ b/sysdeps/unix/sysv/linux/posix_fallocate64.c >> @@ -32,8 +32,8 @@ __posix_fallocate64_l64 (int fd, __off64_t offset, __off64_t len) >> SYSCALL_LL64 (offset), SYSCALL_LL64 (len)); >> if (! INTERNAL_SYSCALL_ERROR_P (res)) >> return 0; >> - if (INTERNAL_SYSCALL_ERRNO (res) != EOPNOTSUPP) >> - return INTERNAL_SYSCALL_ERRNO (res); >> + if (-res != EOPNOTSUPP) >> + return -res; >> return internal_fallocate64 (fd, offset, len); >> } >> libc_hidden_def (__posix_fallocate64_l64) > > -res == EOPNOTSUPP is inconsistent with the rest of the patch. Do you mean change to 'res == -EOPNOTSUPP) ? > >> diff --git a/sysdeps/unix/sysv/linux/pthread_sigqueue.c b/sysdeps/unix/sysv/linux/pthread_sigqueue.c >> index 4b32be2d64..fbbd9fee20 100644 >> --- a/sysdeps/unix/sysv/linux/pthread_sigqueue.c >> +++ b/sysdeps/unix/sysv/linux/pthread_sigqueue.c >> @@ -63,8 +63,7 @@ pthread_sigqueue (pthread_t threadid, int signo, const union sigval value) >> /* We have a special syscall to do the work. */ >> int val = INTERNAL_SYSCALL_CALL (rt_tgsigqueueinfo, pid, tid, signo, >> &info); >> - return (INTERNAL_SYSCALL_ERROR_P (val) >> - ? INTERNAL_SYSCALL_ERRNO (val) : 0); >> + return INTERNAL_SYSCALL_ERROR_P (val) ? -val : 0; >> #else >> return ENOSYS; >> #endif > > This could use plain -val. > >> diff --git a/sysdeps/unix/sysv/linux/s390/s390-32/posix_fadvise64.c b/sysdeps/unix/sysv/linux/s390/s390-32/posix_fadvise64.c >> index b556a6caae..6199589307 100644 >> --- a/sysdeps/unix/sysv/linux/s390/s390-32/posix_fadvise64.c >> +++ b/sysdeps/unix/sysv/linux/s390/s390-32/posix_fadvise64.c >> @@ -43,9 +43,7 @@ __posix_fadvise64_l64 (int fd, off64_t offset, off64_t len, int advise) >> parameters.len = len; >> parameters.advise = advise; >> int ret = INTERNAL_SYSCALL_CALL (fadvise64_64, ¶meters); >> - if (!INTERNAL_SYSCALL_ERROR_P (ret)) >> - return 0; >> - return INTERNAL_SYSCALL_ERRNO (ret); >> + return INTERNAL_SYSCALL_ERROR_P (ret) ? -ret : 0; >> } >> >> #include > > See above, plain -ret should be okay. > > > The patch relies on a GCC extension because in the error case, -res is a > large unsigned value which cannot be represented in an int. But I think > this is okay. I think with subsequent patches where it moves towards inline functions with a more well typed interface should make the internal syscall interface more well-defined.