From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Joseph Myers <joseph@codesourcery.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] crypt: Use internal names for the SHA-2 block functions
Date: Fri, 28 Oct 2016 17:57:00 -0000 [thread overview]
Message-ID: <49a0f49e-b22c-2dd1-fa5b-bbad89e8aacb@linaro.org> (raw)
In-Reply-To: <alpine.DEB.2.20.1610281705260.17460@digraph.polyomino.org.uk>
On 28/10/2016 15:09, Joseph Myers wrote:
> On Fri, 28 Oct 2016, Adhemerval Zanella wrote:
>
>> It should __sha256_process_block_generic here. Also, if we now aiming
>> for namespace clean shouldn't we also add a conform test for crypt.h
>> header?
>
> crypt.h is not in any standard supported by the conform tests.
>
> It's true that linknamespace considerations apply even for _DEFAULT_SOURCE
> and _GNU_SOURCE - using a function declared under one of those conditions
> should not bring in a reference to a function not so declared. The
> difficulty in testing this is that it really needs a list of all installed
> headers to be visible in one place (and there's the question of whether we
> consider _DEFAULT_SOURCE to include all headers or not).
>
Right, but how hard would to add a rule in conform to tests for glibc specific
headers (conformtest-headers-GLIBC or conformtest-headers-GNU) and at
first add the crypt.h plus _GNU_SOURCE?
next prev parent reply other threads:[~2016-10-28 17:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 12:57 Florian Weimer
2016-10-28 13:32 ` Adhemerval Zanella
2016-10-28 17:09 ` Joseph Myers
2016-10-28 17:57 ` Adhemerval Zanella [this message]
2016-10-28 18:07 ` Joseph Myers
2016-10-28 20:05 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49a0f49e-b22c-2dd1-fa5b-bbad89e8aacb@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).