From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-106122-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 33953 invoked by alias); 18 Oct 2019 20:02:30 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 33895 invoked by uid 89); 18 Oct 2019 20:02:30 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-9.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1311, 0755
X-HELO: us-smtp-delivery-1.mimecast.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1571428947;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=XV4cAfZAqQrDWSTuutc4gKbwVGvsWcPBLciilMAAB3E=;
	b=V2olyCEQbTCOVvQR/TSJ06hd7UW0HvIeuTTY1Sa5FwqaxMHZvmaB+aox/nRPNI6vCSPAIL
	Quzct4FODxoC4dWlGTTYVlVH2veTGhDXnqSCjG4hrF1fzfstk/FZVX43NQddWUHIU7hwW6
	+FDJYArHx17Y2mMhlugoyJi4EwkLF9g=
Return-Path: <carlos@redhat.com>
Subject: Re: [PATCH 2/2] elf: Use nocancel pread64() instead of lseek()+read()
From: Carlos O'Donell <carlos@redhat.com>
To: Leandro Pereira <Leandro.Pereira@microsoft.com>,
 "libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
References: <MWHPR2101MB073287753F9E8D211AF49DD3E8DA0@MWHPR2101MB0732.namprd21.prod.outlook.com>
 <b6d92327-1add-d95a-6606-7a270bcbec55@redhat.com>
Message-ID: <4a05e103-4c17-92d6-1816-4d6f17922ef7@redhat.com>
Date: Fri, 18 Oct 2019 20:02:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <b6d92327-1add-d95a-6606-7a270bcbec55@redhat.com>
X-Mimecast-Spam-Score: 0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-SW-Source: 2019-10/txt/msg00585.txt.bz2

On 10/3/19 9:59 AM, Carlos O'Donell wrote:
> On 8/5/19 5:56 PM, Leandro Pereira wrote:
>> Transforms this, when linking in a shared object:
>>
>>   openat(AT_FDCWD, "/lib64/libc.so.6", O_RDONLY|O_CLOEXEC) =3D 3
>>   read(3, "\177ELF\2\1\1\3"..., 832) =3D 832
>>   lseek(3, 792, SEEK_SET)           =3D 792
>>   read(3, "\4\0\0\0\24\0\0\0"..., 68) =3D 68
>>   fstat(3, {st_mode=3DS_IFREG|0755, st_size=3D6699224, ...}) =3D 0
>>   lseek(3, 792, SEEK_SET)           =3D 792
>>   read(3, "\4\0\0\0\24\0\0\0"..., 68) =3D 68
>>   lseek(3, 864, SEEK_SET)           =3D 864
>>   read(3, "\4\0\0\0\20\0\0\0"..., 32) =3D 32
>>
>> Into this:
>>
>>   openat(AT_FDCWD, "/lib64/libc.so.6", O_RDONLY|O_CLOEXEC) =3D 3
>>   read(3, "\177ELF\2\1\1\3"..., 832) =3D 832
>>   pread(3, "\4\0\0\0\24\0\0\0"..., 68, 792) =3D 68
>>   fstat(3, {st_mode=3DS_IFREG|0755, st_size=3D6699224, ...}) =3D 0
>>   pread(3, "\4\0\0\0\24\0\0\0"..., 68, 792) =3D 68
>>   pread(3, "\4\0\0\0\20\0\0\0"..., 32, 864) =3D 32
>>
>> 2019-08-05  Leandro Pereira  <leandro.pereira@microsoft.com>
>>
>> 	* elf/dl-load.c: Use __pread64_nocancel() instead of __lseek()+
>> 	__read_nocancel().
>> 	* sysdeps/x86/dl-prop.h: Likewise.
>=20
> OK for master. I'll push after testing with bmg. No regressions on x86_64.
>=20
> Reviewed-by: Carlos O'Donell <carlos@redhat.com>

Pushed.

--=20
Cheers,
Carlos.