From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from olivedrab.birch.relay.mailchannels.net (olivedrab.birch.relay.mailchannels.net [23.83.209.135]) by sourceware.org (Postfix) with ESMTPS id 03E9138515EB for ; Wed, 9 Jun 2021 18:29:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 03E9138515EB X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 657D31E2188; Wed, 9 Jun 2021 18:29:02 +0000 (UTC) Received: from pdx1-sub0-mail-a68.g.dreamhost.com (100-96-16-78.trex.outbound.svc.cluster.local [100.96.16.78]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id A52B31E228B; Wed, 9 Jun 2021 18:29:01 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a68.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.16.78 (trex/6.3.1); Wed, 09 Jun 2021 18:29:02 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Wipe-Supply: 490626905b359336_1623263341908_2399595025 X-MC-Loop-Signature: 1623263341908:1880880291 X-MC-Ingress-Time: 1623263341907 Received: from pdx1-sub0-mail-a68.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a68.g.dreamhost.com (Postfix) with ESMTP id 5D64B7E4C2; Wed, 9 Jun 2021 11:29:01 -0700 (PDT) Received: from [192.168.1.126] (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a68.g.dreamhost.com (Postfix) with ESMTPSA id 45A6D7E4B5; Wed, 9 Jun 2021 11:28:57 -0700 (PDT) Subject: Re: [PATCH] Handle DT_UNKNOWN in gconv-modules.d To: Florian Weimer , Siddhesh Poyarekar via Libc-alpha Cc: schwab@linux-m68k.org References: <20210609043835.218509-1-siddhesh@sourceware.org> <637d9c58-610a-e68f-b743-85c99e18be1d@sourceware.org> <874ke651xa.fsf@oldenburg.str.redhat.com> X-DH-BACKEND: pdx1-sub0-mail-a68 From: Siddhesh Poyarekar Message-ID: <4aca1d23-978f-ab71-82e2-67832f6a7a37@sourceware.org> Date: Wed, 9 Jun 2021 23:58:52 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <874ke651xa.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3487.1 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2021 18:29:05 -0000 On 6/9/21 11:57 PM, Florian Weimer via Libc-alpha wrote: > * Siddhesh Poyarekar via Libc-alpha: > >>> But I think we should move away from alloca, even when we know it >>> is bounded (sorry if I didn't catch on the previous patch). For >>> this specific usage we can use asprintf to create the path or use >>> a static PATH_MAX buffer. >> >> I agree, a static PATH_MAX makes sense, I'll do that. > > PATH_MAX is not available on Hurd. (grumbling redacted)