Re: [PATCH v6 3/3] linux: Set internal DIR filepos as off64_t (BZ #23960, BZ #24050)

[Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>]

On 13/03/23 09:40, Adhemerval Zanella Netto wrote:
>>
>>> +_Static_assert (sizeof (long int) == sizeof (off64_t),
>>> +        "sizeof (long int) != sizeof (off64_t)");
>>
>> This is confusing. First, we need require only that long int be at least as wide as off64_t; it doesn't have to be exactly the same width. Second, why both "==" and "!="? Third, why not use plain "static_assert" with one arg instead of the old-fashioned "_Static_assert" with two? We can support this form of static_assert on older compilers - see how Gnulib does it.
> 
> Indeed, we already set _DIRENT_OFFSET_TRANSLATION for (LONG_WIDTH < 64)
> so maybe I think we should replace with 64 with sizeof (off_64) and
> remove the static assert. 

And I just realized that sizeof is not usable on preprocessor context,
so I will fix the static assert.  And I don't really want to pull another
huge gnulib header that we might eventually phase out once we start to use
a std that provides static_assert (we might revise it later).