From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id 030A03851C36 for ; Mon, 29 Mar 2021 20:35:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 030A03851C36 Received: by mail-wr1-x42a.google.com with SMTP id b9so14096751wrt.8 for ; Mon, 29 Mar 2021 13:35:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RnFXtnWs3QMX4G9CQYVoZHqijVhTVCwOl7jN2p2nqCI=; b=SJlHhWBPw1rAh8ZTas/Hvefct08YnAHf9yoM8VHU/iD/KWQH1tFcLJlv00lPdGr1Qg YVhZNloYxPm/KXfqfftsMfcqqcTPXYknAzp9FSnBQrzQTKUAagd3L0dUYdI5Pgv0i+ww tg5gHKErLpMsXdl11Kfgl2JiLLB5Rqv2CNoD/PYx0jdXvQYjm4PtrVaVTdgcf4VaN++M iAU1K6ERC51kp8dUvaKtU29bSg2y5XGxoTrduuxmT35oWppNMKfVz+2QtJ8METEuPQbq KPfr49o8TJ5D2X3VRsI55Cfacvxspl3P3mi4WI3zRG//MSEReFM9CrLP2/kVKKGMDLUK mcjg== X-Gm-Message-State: AOAM5303oe01PY5KKgQGzFUGpCJjlQZ5Ks1wvIik1WN2TgnKGBo/l2mZ NySpX752l+x+FLqJo63bwlrGidNpdzc= X-Google-Smtp-Source: ABdhPJzfmrycE8kDGgWBdVCQ7hCLEDKTCu4NIuJt99aHGFJQglaAR77se2Y/0Bi8sFzRsPIg3e94NQ== X-Received: by 2002:adf:ec8c:: with SMTP id z12mr30065818wrn.405.1617050116077; Mon, 29 Mar 2021 13:35:16 -0700 (PDT) Received: from [192.168.0.160] ([170.253.36.171]) by smtp.gmail.com with ESMTPSA id i26sm571128wmb.18.2021.03.29.13.35.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Mar 2021 13:35:15 -0700 (PDT) Subject: Re: [PATCH] stdio-common/printf-prs.c: Simplify test To: Adhemerval Zanella , libc-alpha@sourceware.org References: <20210324180718.28006-1-alx.manpages@gmail.com> <0a435dd4-2ea3-952e-d8bf-72cf3a7b6105@linaro.org> From: "Alejandro Colomar (man-pages)" Message-ID: <4ad8aa37-2efa-3eb5-3c10-455993ef6cb7@gmail.com> Date: Mon, 29 Mar 2021 22:35:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <0a435dd4-2ea3-952e-d8bf-72cf3a7b6105@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Mar 2021 20:35:18 -0000 On 3/29/21 9:32 PM, Adhemerval Zanella wrote: > > > On 24/03/2021 15:07, Alejandro Colomar via Libc-alpha wrote: >> The test was being repeated for all the remaining code in the for loop. >> Test once, and 'continue' to next iteration if necessary, so that the >> following code can assume that the necessary condition is met. >> >> Minor changes: fix some mixed tabs & spaces to use spaces only. >> >> Signed-off-by: Alejandro Colomar > > We do not use SCO, but rather Copyright assignment. And I think we will > need to add a testcase for this change, this simple program below shows > a complete different result with this patch applied: > Hello Adhemerval, Yes, I was completely wrong with that patch. I submitted a patch v2 after that, trying to improve the comments (without the code changes, which were wrong) to avoid confusion: . Thanks, Alex -- Alejandro Colomar Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/ http://www.alejandro-colomar.es/