From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bumble.maple.relay.mailchannels.net (bumble.maple.relay.mailchannels.net [23.83.214.25]) by sourceware.org (Postfix) with ESMTPS id 28F5F3858D1E for ; Tue, 3 Jan 2023 14:43:31 +0000 (GMT) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 825AD6C11C0; Tue, 3 Jan 2023 14:43:30 +0000 (UTC) Received: from pdx1-sub0-mail-a305.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 5E2506C1276; Tue, 3 Jan 2023 14:43:29 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1672757009; a=rsa-sha256; cv=none; b=HDVm35BEemJDm/3DkcWX8Uv9gkJN+0p9qqsMXB9QERmSYwNNOZ6uCKWJ8GkMY/2oAzRYwb glsJPjXnIg9fbSbugdILieZilRfHJIdSutFhqjZHyoHB+sFSolQcRBbjBh5QEDVazjwJud RK68NARGqVAZsyXd6lK5rmHrm3OhKE5/OBAUQsn+SsYP9+d/TWU1lIIOvDrispx++S4QQ1 yOsb7AzYTMdVQOysmmThrVouLG4of9xF0gm6hEGoBsbXRl09yRE00DyVlE4EPQD6mawb88 BaIx/PcH/hec2oZGRRZc7eUT++Y7xfScrW6/YQR/8R0aNjdrahyFKNJEfn6TPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1672757009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a8bUDtYy3CnJVycjxeuhJvUIgHYR6XDv8ypl5RfvmJ0=; b=gSQ+OMPWE5wubkNYz75Vym0vXY/DSbNoyjv7dcLiU2atBVb1wHP2JifUiKyT2iJs7Ag93r 3RsWY6MgONyKepYqvrqxLfi7hs5Kp9yzsMXh05xKfo8f+GfBkWGYdj4pSxwsw5lvH01vqi Wvfnp52FWGGRTv4qpOGoZA28vpynTizzuG0h6na7uA8AgKJKvJ01HLc8EmZB0eycIb5IX4 PNI25qnyzZieuaON3x53AuZXBVgDLMH2m24O4eDhvLZWl4KcSNsAwww99STlt0GLBYm8t5 64knBFS0/fs7EjzkBHylEwIanchIRRH2tYvZeHjk1JtHoOylmvfR+XR/yDV7Vg== ARC-Authentication-Results: i=1; rspamd-698c4479bb-kvtg4; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@sourceware.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Troubled-Soft: 4d2ce4ac176754d1_1672757010077_241104584 X-MC-Loop-Signature: 1672757010077:2362478648 X-MC-Ingress-Time: 1672757010077 Received: from pdx1-sub0-mail-a305.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.107.134.72 (trex/6.7.1); Tue, 03 Jan 2023 14:43:30 +0000 Received: from [192.168.0.182] (bras-base-toroon4834w-grc-23-76-68-24-147.dsl.bell.ca [76.68.24.147]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a305.dreamhost.com (Postfix) with ESMTPSA id 4Nmb801xWszDy; Tue, 3 Jan 2023 06:43:28 -0800 (PST) Message-ID: <4b05d5c5-b418-4dcc-0aa9-a02cb6000d73@sourceware.org> Date: Tue, 3 Jan 2023 09:43:26 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] Add _FORTIFY_SOURCE implementation documentation [BZ #28998] Content-Language: en-US To: Sam James Cc: libc-alpha@sourceware.org, fweimer@redhat.com References: <20221215162506.1802077-1-siddhesh@sourceware.org> <6E441F3E-97B4-4A4E-B876-618D12EEDCF4@gentoo.org> From: Siddhesh Poyarekar In-Reply-To: <6E441F3E-97B4-4A4E-B876-618D12EEDCF4@gentoo.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1167.5 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_SOFTFAIL,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-12-22 08:08, Sam James wrote: > > >> On 22 Dec 2022, at 12:56, Siddhesh Poyarekar wrote: >> >> Ping! Any further comments other than the redundant 'See' Andreas noted? >> > > It looks good & thanks for doing it. > > I wonder if it's worth noting (maybe it's obvious) that tools which > make use of LD_PRELOAD may need to provide their own wrappers. > > (umockdev being an example I'm thinking of here.) Hi Sam, sorry I missed your response (and funnily, I got 3 of them!). I'm not sure, there are other issues with interposing, e.g. string function calls where the result is already dependent on how the compiler treats those calls, making the result of the interposition kinda indeterminate across builds. So I don't know how useful it would be to call it out specifically in the context of _FORTIFY_SOURCE. However, I don't think it's a bad idea to do so either (i.e. I don't see it imposing any constraints on us as implementers), so if you like it (and others don't express a dislike), I'll be happy to add a note in there. If there's a positive review for the latest version of this patch, I'll post it as an add-on fix or else I'll include it in the next version of the patch. Thanks, Sid