From: Joseph Myers <joseph@codesourcery.com>
To: Alejandro Colomar <alx.manpages@gmail.com>
Cc: Zack Weinberg <zack@owlfolio.org>,
Wilco Dijkstra <Wilco.Dijkstra@arm.com>,
Carlos O'Donell <carlos@redhat.com>,
'GNU C Library' <libc-alpha@sourceware.org>
Subject: Re: Bug 29863 - Segmentation fault in memcmp-sse2.S if memory contents can concurrently change
Date: Fri, 30 Dec 2022 18:02:01 +0000 [thread overview]
Message-ID: <4b1f7f41-535-8947-80c1-662768db9235@codesourcery.com> (raw)
In-Reply-To: <2a6f6912-592a-b82b-0efb-ea985dea2548@gmail.com>
On Thu, 29 Dec 2022, Alejandro Colomar via Libc-alpha wrote:
> Okay, probably it's not the fastest one, but it's simple. This one would
> SIGSEGV in the following case:
>
> Another thread might insert a NUL at the beginning of each string (after the
> loop has passed over it), and in the next cycle remove the
> previously-terminating NUL from the strings. The loop would then run forever,
> until a crash.
I also think it should be OK for strcmp to SEGV if a NUL terminator byte
in either string at the time strlen is called, or at any time during its
execution, ceases at any point during the execution of strlen to be a NUL
byte (even if there is an earlier or later NUL already present at the time
the terminator byte is changed). (There is a reasonable case for avoiding
a SEGV when the contents of the strings change during execution, as long
as any byte that is the NUL terminator byte at any point during execution
of the call never ceases to be a NUL byte during execution of that call -
an earlier NUL might be added, however.)
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2022-12-30 18:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <PAWPR08MB89825887E12FF900540365F483E09@PAWPR08MB8982.eurprd08.prod.outlook.com>
[not found] ` <PAWPR08MB898260DA844D695EA70ED3E483E09@PAWPR08MB8982.eurprd08.prod.outlook.com>
2022-12-14 21:56 ` Wilco Dijkstra
2022-12-29 7:21 ` Zack Weinberg
2022-12-29 20:02 ` Alejandro Colomar
2022-12-30 18:02 ` Joseph Myers [this message]
2023-03-20 15:40 ` Zack Weinberg
2022-12-13 18:20 Narayanan Iyer
2022-12-13 18:31 ` Andrew Pinski
2022-12-13 18:39 ` Narayanan Iyer
2022-12-13 18:39 ` Cristian Rodríguez
2022-12-13 19:08 ` Noah Goldstein
2022-12-13 19:13 ` Narayanan Iyer
2022-12-13 19:25 ` Noah Goldstein
2022-12-13 20:56 ` Zack Weinberg
2022-12-13 23:29 ` Carlos O'Donell
2022-12-14 2:28 ` Zack Weinberg
2022-12-14 4:16 ` Carlos O'Donell
2022-12-14 14:16 ` Zack Weinberg
2022-12-14 17:36 ` Paolo Bonzini
2022-12-29 7:09 ` Zack Weinberg
2022-12-13 21:20 ` Florian Weimer
2022-12-13 22:59 ` Noah Goldstein
2022-12-14 12:06 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b1f7f41-535-8947-80c1-662768db9235@codesourcery.com \
--to=joseph@codesourcery.com \
--cc=Wilco.Dijkstra@arm.com \
--cc=alx.manpages@gmail.com \
--cc=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=zack@owlfolio.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).