From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) by sourceware.org (Postfix) with ESMTPS id 363023858D28 for ; Wed, 29 Dec 2021 13:08:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 363023858D28 Received: by mail-qk1-x72e.google.com with SMTP id 69so19814817qkd.6 for ; Wed, 29 Dec 2021 05:08:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=mg+ApmhXta1a7ChVCAN9J3ln4V9khtoHcQ6cTMdLZE4=; b=CjiW/v6W1pFUekHZXGOLOJGZnqp/lcVkQ0yDeEIJlVgJkkWaIrv67Sc9xUX5HeFFi/ 1ZLZf2y3OauAroCImqdnnFlDiSs/W6yR9mPHVUJM+3KrFlFSsNz/IinWWZ7TwKtzj1iu kYpURvUkMcr38a1Wvg4GOhjRoO8/5KoW9K1cDIJnjvz9RptQJ7fdfmAEcvqzUOCu4sZj gJ9ImIxV+jsR03vfEXL2Y9GVy+zQSGtZq/phg5P29VwE7HcmKjZMiabvlaM3zHgat26b QACDfcp5gE3OIE3h0IbZxmpYGjWM7qgUnO6ttorguvHS6Tm6i3twbCksA89kxP84oQRz kuMw== X-Gm-Message-State: AOAM530zPdobJGtVqkwZCXGXl+qKlAdtyl+f+ElUfB/027GmkdgeSQf9 L8wYKlwxRjZtext10AirM6ApcOsLviULTA== X-Google-Smtp-Source: ABdhPJw2mnQPWzxuBzpK7eWLn0JpZj0F/gBEZTlGiOXcN/GYfWRQAlnkEFEl4aLFDvLpUGMNByb7Mg== X-Received: by 2002:a05:620a:400f:: with SMTP id h15mr18827383qko.226.1640783333545; Wed, 29 Dec 2021 05:08:53 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:a350:349e:1fa8:ba3d:5b36? ([2804:431:c7ca:a350:349e:1fa8:ba3d:5b36]) by smtp.gmail.com with ESMTPSA id bq43sm17224699qkb.32.2021.12.29.05.08.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Dec 2021 05:08:53 -0800 (PST) Message-ID: <4b222a15-5249-98a2-4aba-117e20489863@linaro.org> Date: Wed, 29 Dec 2021 10:08:51 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v2] Use LFS and 64 bit time for installed programs (BZ #15333) Content-Language: en-US To: Florian Weimer Cc: Adhemerval Zanella via Libc-alpha References: <20210622172713.3504003-1-adhemerval.zanella@linaro.org> <87ilv8cvov.fsf@oldenburg.str.redhat.com> <8021a5c8-1c46-49fc-6950-6612a4a7a618@linaro.org> <87h7arbnc1.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <87h7arbnc1.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Dec 2021 13:09:01 -0000 On 29/12/2021 09:35, Florian Weimer wrote: > * Adhemerval Zanella: > >> On 28/12/2021 17:37, Florian Weimer wrote: >>> * Adhemerval Zanella via Libc-alpha: >>> >>>> The installed programs are built with a combination of different >>>> values for MODULE_NAME, as below. To enable both Long File Support >>>> and 64 bt time, -D_TIME_BITS=64 -D_FILE_OFFSET_BITS=64 is added for >>>> nonlibi, nscd, lddlibc4, libresolv, ldconfig, locale_programs, >>>> iconvprogs, libnss_files, libnss_compat, libnss_db, libnss_hesiod, >>>> libutil, libpcprofile, and libSegFault. >>> >>> -D_TIME_BITS=64 does not work for building glibc because the internal >>> aliases such as __fstat64 do not follow _TIME_BITS and are hard-wired to >>> 32-bit time. A symptom is a broken ldconfig, e.g.: >>> >>> $ elf/ldconfig -p >>> elf/ldconfig: mmap of cache file failed. >>> : Invalid argument >> >> I think the real problem is the usage of internal symbol in installed >> binaries, it works for LFS stat because they are either redirected to >> compat xstat ones or __stat (which I think it is also error prone). >> >> I am fixing it by using the default stat names, installed programs >> should not use proper LFS and time64. > > They need to be able to deal with 64-bit inode numbers, though. Oops, I meant that installed programs *should* use proper LFS and time64 (using default stat names accomplish it for static linking).