From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id 2D6DF3858CDA for ; Mon, 20 May 2024 19:04:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2D6DF3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2D6DF3858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::42a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716231870; cv=none; b=ZJt8CCXTa2nblZhSNP/JWL6WX2Lh2ZjvEO+9GfG2m7+KNk6d5NE0wCVfLltZUoMqzyGcgulQt4GPO9to6+ZslvRS35aL3XCVsapYQixtKTsQvWOg7WKK920J7DFaEFD79DXTQr6VhRsFJMUISNQyU/11xEas/Zhaj6gvpneqF5o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716231870; c=relaxed/simple; bh=ipyLPYulpxsDkEsX0NWpiIky227Hmx8pFbVIs0YD9m8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=NrkfzWS6A6mFIyFUXRZHDf5riFai5G/mpzHPaVDSJlwFAGumC55KPvfvgUoQhi5C7wR/jHPye+psf/HM5Q9tkjph99OL/nSVi3o3loifUSXz7o0GJme1mjJXT7t+5TkcgUwaj2psHrBj4JdYOzYvXhOPy9/jkJerraiwIenLh3k= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-6f467fb2e66so1288044b3a.1 for ; Mon, 20 May 2024 12:04:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716231866; x=1716836666; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=flcdd3s6vKCU1nd+WU5kAZOxVkJkORw2nSL5I5vpsbY=; b=Y0aOvfeLBHUsx+UrARhQXScXe2Dw0ABYP8Oxsemz03JBS/z4ZNqkfRGRikTnIQimnm AhbmhMtgLYxCYMrULSk5KcGd4wn/yotJ4T/ujcBZQ+I8IDXReT52phjrkzbPs4ZWwU0R MkhqEuX7XWTVjVDlnc83NBycdFnCc5hJOONK5IOMMV1LJlqbrTZOkQnO6QKmg+rOX/Wy CMxXLHeuyz13XTY+uVt2I6ZAUsNCnLdeBS0orGw9vMY8Fc9aOatV1S+381kYc5BT88Xg u1fxMiVNDoTmoEz3H4MmZp/Oi7buHMe5UbajoUxXR9LTLiYXsDLbEAJbDNtgb7Sl15P6 b0eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716231866; x=1716836666; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=flcdd3s6vKCU1nd+WU5kAZOxVkJkORw2nSL5I5vpsbY=; b=gAQ4R3+//h+t0/9WO2BQ8eCz8AyRdkv8UC5rGBAYbQjQt7Kn3VYx+V2rmP/qDqHi3c T6unNAgDno6DKTLG3QQaegsVlLQSu69IqA7MHGHyt+Y+HnNLITAIzV6B6MRCKZiOsliC JiPxz0TRp/3aN9zh4GbwfJLanw6F+Yw0apaai/IVryY2nCJD5MaLB2+MG4JEJ9wTz2c7 EDEanHZ+oLp+0n9EBn60krgGL89sXD+jovImRMo2f4LQb5FbaO4ZMtJg5D6PQPpcmnju xfOid64ibbZ4h48QjdMrixkGNYLAlFaJdmj4HeLtKaAUMf/lwptdGromtF5ieg2djnyL Nscw== X-Gm-Message-State: AOJu0YzDrtSnTGD7IoOxun9f2FjbDZ6tfgZy7s+IIHlY8AdmBiENbpxV 9T3TeY8cqQv3kYYNnPGldg+RzcYJNnTZ/BiEPYS84y0kgzcKZ2WQ6SYJuP+Xy9ECXI4GBnoM4Wx 8 X-Google-Smtp-Source: AGHT+IFNjOAYzkuMjysDlnUqRd/sFWZxuc8Skw+WXBo0Ti+3R4o3RQE/UTGiu8Gini684MbkvZJOKQ== X-Received: by 2002:a05:6a00:1483:b0:6ea:f422:64ce with SMTP id d2e1a72fcca58-6f4e03a3acfmr41121344b3a.33.1716231865750; Mon, 20 May 2024 12:04:25 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c2:f76a:4d8e:551e:8ee4:7221? ([2804:1b3:a7c2:f76a:4d8e:551e:8ee4:7221]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f4fa8db6a2sm15967081b3a.177.2024.05.20.12.04.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 May 2024 12:04:25 -0700 (PDT) Message-ID: <4b34a034-0749-4c71-aeff-0077a7456307@linaro.org> Date: Mon, 20 May 2024 16:04:22 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/7] math: Provided copysignf128 for static libm on alpha, s390, and sparcv9 To: "H.J. Lu" Cc: libc-alpha@sourceware.org, Joseph Myers , Florian Weimer References: <20240402140644.2172819-1-adhemerval.zanella@linaro.org> <20240402140644.2172819-6-adhemerval.zanella@linaro.org> Content-Language: en-US From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 20/05/24 13:55, H.J. Lu wrote: > On Tue, Apr 2, 2024 at 7:07 AM Adhemerval Zanella > wrote: >> >> Checked with a static build for the affected ABIs. >> --- >> sysdeps/ieee754/ldbl-64-128/s_copysignl.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/sysdeps/ieee754/ldbl-64-128/s_copysignl.c b/sysdeps/ieee754/ldbl-64-128/s_copysignl.c >> index 11b42d04ba..80137847d3 100644 >> --- a/sysdeps/ieee754/ldbl-64-128/s_copysignl.c >> +++ b/sysdeps/ieee754/ldbl-64-128/s_copysignl.c >> @@ -1,10 +1,10 @@ >> #include >> #include >> -#if IS_IN (libc) >> +#if IS_IN (libc) && defined SHARED >> # undef libm_alias_ldouble >> # define libm_alias_ldouble(from, to) >> #endif >> #include >> -#if IS_IN (libc) >> +#if IS_IN (libc) && defined SHARED > > Doesn't this remove copysignl from libm.a? There is no copysignl from libm.a, it is provided by libc.a for such ABIs. Without this path: alpha-linux-gnu$ readelf -sW libc.a | grep -w copysign.* 14: 0000000000000000 52 FUNC WEAK DEFAULT [NOPV] 1 copysignl 14: 0000000000000000 8 FUNC WEAK DEFAULT [NOPV] 1 copysignf32x 15: 0000000000000000 8 FUNC WEAK DEFAULT [NOPV] 1 copysignf64 16: 0000000000000000 8 FUNC WEAK DEFAULT [NOPV] 1 copysign 14: 0000000000000000 8 FUNC WEAK DEFAULT [NOPV] 1 copysignf32 15: 0000000000000000 8 FUNC WEAK DEFAULT [NOPV] 1 copysignf After this patch: alpha-linux-gnu$ readelf -sW libc.a | grep -w copysign.* 14: 0000000000000000 52 FUNC WEAK DEFAULT [NOPV] 1 copysignf64x 15: 0000000000000000 52 FUNC WEAK DEFAULT [NOPV] 1 copysignf128 16: 0000000000000000 52 FUNC WEAK DEFAULT [NOPV] 1 copysignl 14: 0000000000000000 8 FUNC WEAK DEFAULT [NOPV] 1 copysignf32x 15: 0000000000000000 8 FUNC WEAK DEFAULT [NOPV] 1 copysignf64 16: 0000000000000000 8 FUNC WEAK DEFAULT [NOPV] 1 copysign 14: 0000000000000000 8 FUNC WEAK DEFAULT [NOPV] 1 copysignf32 15: 0000000000000000 8 FUNC WEAK DEFAULT [NOPV] 1 copysignf > >> long_double_symbol (libc, __copysignl, copysignl); >> #endif >> -- >> 2.34.1 >> > >