From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) by sourceware.org (Postfix) with ESMTPS id AF198394D8A6 for ; Wed, 24 Feb 2021 13:31:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AF198394D8A6 Received: by mail-qk1-x732.google.com with SMTP id d20so1055395qkc.2 for ; Wed, 24 Feb 2021 05:31:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=EphNccyY2CQ+6QaUFagpuQJqM9OUEKr2kpO1VNZrffs=; b=jQngwXZfXlu7lxYgFPuEiVSvPZ7I0Men4Q8ch4KGUO3ICS3BEUgQbijw9soppyG9fu 03kB76LJEujbaio42KQIxtbdyzayVsj4BnRaaj1eHTOFPrV0+/BfRJnwcAZX0eXZjmrR NviAHoaiBqPUhFhQJy05tkGhYiXbyrg32KB/Lth2yoxA6Sob0guS3X9jIs/u2vy3wu+Z 9mfZwO9nkDDkNWGZliVwmh6SDKVcgd6GhYgljwn0Rs8OGL8F1SqMOlPjR5Fg/JmfUqDW 4mTmLHjPLHYgMj3uv8q5HJwlekJe6Bv0qWkGzcAFSDH9LwCdDj7iuaO218OkjhjH+RTl yyew== X-Gm-Message-State: AOAM5304qONAcR8XHcZ9CLOJA3fj/3e1UjnoUJKBaC29h5kREtDDG6g5 tR7fa8ID0i1xEdBKPkWKSaWESxtQdEEtUA== X-Google-Smtp-Source: ABdhPJwz8Bqj8WjOMkoYImt02o+Cy4sWM2DQ9q6vED+84DdU1oMsSUEpttXe75YPKtquhWbB17meHw== X-Received: by 2002:a05:620a:49d:: with SMTP id 29mr30997537qkr.49.1614173470180; Wed, 24 Feb 2021 05:31:10 -0800 (PST) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id q12sm1416609qki.91.2021.02.24.05.31.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Feb 2021 05:31:09 -0800 (PST) Subject: Re: [PATCH v2] tst: Add test for clock_adjtime To: Lukasz Majewski Cc: Joseph Myers , Florian Weimer , DJ Delorie , Paul Eggert , Alistair Francis , Arnd Bergmann , Alistair Francis , GNU C Library , Carlos O'Donell , Florian Weimer , Zack Weinberg References: <20210217232435.24045-1-lukma@denx.de> <6963d676-c818-b8d8-c019-c97efe4c77c3@linaro.org> <20210224141832.71095620@jawa> From: Adhemerval Zanella Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Message-ID: <4b68452d-a33a-ea59-9ca1-4cd77f0da819@linaro.org> Date: Wed, 24 Feb 2021 10:31:05 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210224141832.71095620@jawa> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Feb 2021 13:31:12 -0000 On 24/02/2021 10:18, Lukasz Majewski wrote: > Hi Adhemerval, > >> On 17/02/2021 20:24, Lukasz Majewski wrote: >>> This code brings test to check if time on target machine is properly >>> adjusted. >>> The time is altered only when cross-test-ssh.sh is executed with >>> --allow-time-setting flag >>> As the delta added to CLOCK_REALTIME is only 1ms the original time >>> is not restored and further tests are executed with this bias. >>> >>> --- >>> Changes for v2: >>> - Use timespec_sub and support_timespec_check_in_range to check if >>> time has been adjusted properly >>> --- >>> time/Makefile | 2 +- >>> time/tst-clock_adjtime.c | 59 >>> ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 60 >>> insertions(+), 1 deletion(-) create mode 100644 >>> time/tst-clock_adjtime.c >>> >>> diff --git a/time/Makefile b/time/Makefile >>> index b6f0969f3d..fc6415bf8a 100644 >>> --- a/time/Makefile >>> +++ b/time/Makefile >>> @@ -51,7 +51,7 @@ tests := test_time clocktest tst-posixtz >>> tst-strptime tst_wcsftime \ tst-clock tst-clock2 >>> tst-clock_nanosleep tst-cpuclock1 \ tst-adjtime tst-ctime >>> tst-difftime tst-mktime4 tst-clock-y2038 \ tst-clock2-y2038 >>> tst-cpuclock1-y2038 tst-clock_nanosleep-y2038 \ >>> - tst-clock_settime >>> + tst-clock_settime tst-clock_adjtime >>> >>> include ../Rules >>> >> >> Ok. >> >>> diff --git a/time/tst-clock_adjtime.c b/time/tst-clock_adjtime.c >>> new file mode 100644 >>> index 0000000000..f31a4058ec >>> --- /dev/null >>> +++ b/time/tst-clock_adjtime.c >>> @@ -0,0 +1,59 @@ >>> +/* Test for clock_adjtime >>> + Copyright (C) 2021 Free Software Foundation, Inc. >>> + This file is part of the GNU C Library. >>> + >>> + The GNU C Library is free software; you can redistribute it >>> and/or >>> + modify it under the terms of the GNU Lesser General Public >>> + License as published by the Free Software Foundation; either >>> + version 2.1 of the License, or (at your option) any later >>> version. + >>> + The GNU C Library is distributed in the hope that it will be >>> useful, >>> + but WITHOUT ANY WARRANTY; without even the implied warranty of >>> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>> GNU >>> + Lesser General Public License for more details. >>> + >>> + You should have received a copy of the GNU Lesser General Public >>> + License along with the GNU C Library; if not, see >>> + . */ >>> + >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> + >>> +static int >>> +do_test (void) >>> +{ >>> + struct timespec tv_then, tv_now; >>> + struct timex delta; >>> + >>> + /* Check if altering target time is allowed. */ >>> + if (getenv (SETTIME_ENV_NAME) == NULL) >>> + FAIL_UNSUPPORTED ("clock_adjtime is executed only when "\ >>> + SETTIME_ENV_NAME" is set\n"); >> >> Ok. >> >>> + >>> + tv_then = xclock_now (CLOCK_REALTIME); >>> + >>> + /* Setup time value to adjust - 1 ms. */ >>> + delta.time.tv_sec = 0; >>> + delta.time.tv_usec = 1000; >>> + delta.modes = ADJ_SETOFFSET; >> >> Maybe 1 ms is too low? I take that usually the system load on the >> testing scenario would be low, that's why you haven't see a potential >> issue. > > What time value would be more appropriate? 1second? I would go with 1s and check with a range between 10%. It should give some slack if the system time triggers some background daemons, but at same time is large enough that the check would trigger if the time is not changed.