From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) by sourceware.org (Postfix) with ESMTPS id 523363894C39 for ; Mon, 12 Apr 2021 12:20:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 523363894C39 Received: by mail-qt1-x82c.google.com with SMTP id f12so9701684qtf.2 for ; Mon, 12 Apr 2021 05:20:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4OK72N+r0QTcqp+hkx9m/PLraJvHhqP3WJBfJZR0iaU=; b=m+reSuGnUU4DvDVmZrfccs8GwJ4Uds08fyKDpdNORVBnBRZ2+jYTH7MisS7wegv9Vq 4VnN9qm5WpLEK/pwPx+3Tnd84zzRj0AKerwMQwX/hHxcbgZf/F1SAC/mDxuIp6IUJXsm JGHO5cfEq9IiMmIUsg/hXQmaHkXoMp2tr6iuZQS6QBYOZ6rXSJwthPH8VynMXZfOiGG/ BoJv8yry5PY7UD1WuRWO7LmdXAe6wkR9cp7T87FqvYYgFwxmFKn7XNZCbELjDjpP5gA2 up5Udz4QkYMXP0Wpmu7NTXVy9hjG7KSXlf5pIhtV9TyGp3xb3TiKicCCf4jUFa20Vc7R MdPA== X-Gm-Message-State: AOAM531Nm3Coohq1Dw9DlVqByKhmbk8JF5fbqSeqN2jZ9VUE+LFEy7ck rdRWeElscl8gtTvVo4vOb7E0ArQSO0kJNs5+ X-Google-Smtp-Source: ABdhPJxys6ipLFcldzBr7vxORzerLxGWN4exYxRuLwEYIEkeGw0PFgcb0vQs220++lWbYG2VEwawIg== X-Received: by 2002:ac8:5c02:: with SMTP id i2mr24913117qti.159.1618230052703; Mon, 12 Apr 2021 05:20:52 -0700 (PDT) Received: from [192.168.1.132] ([177.194.41.149]) by smtp.gmail.com with ESMTPSA id w4sm7010786qkd.94.2021.04.12.05.20.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Apr 2021 05:20:52 -0700 (PDT) Subject: Re: [PATCH v3 3/4] linux: Normalize and return timeout on select (BZ #27651) To: Andreas Schwab , Adhemerval Zanella via Libc-alpha References: <20210409155346.1357023-1-adhemerval.zanella@linaro.org> <20210409155346.1357023-3-adhemerval.zanella@linaro.org> <875z0r9a9w.fsf@igel.home> From: Adhemerval Zanella Message-ID: <4b770bd2-2c65-fb16-e1fd-cbea990d5a87@linaro.org> Date: Mon, 12 Apr 2021 09:20:49 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <875z0r9a9w.fsf@igel.home> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Apr 2021 12:20:54 -0000 On 12/04/2021 05:28, Andreas Schwab wrote: > On Apr 09 2021, Adhemerval Zanella via Libc-alpha wrote: > >> @@ -52,10 +74,13 @@ __select64 (int nfds, fd_set *readfds, fd_set *writefds, fd_set *exceptfds, >> (though the pselect() glibc call suppresses this behavior). >> Since select() on Linux has the same behavior as the pselect6 >> syscall, we update the timeout here. */ >> - if (r == 0 || errno != ENOSYS) >> + if (r >= 0 || errno != ENOSYS) >> { >> if (timeout != NULL) >> - TIMEVAL_TO_TIMESPEC (timeout, &ts64); >> + { >> + timeout->tv_sec = ts64.tv_sec; >> + timeout->tv_usec = ts64.tv_nsec / NSEC_PER_USEC; >> + } > > What's wrong with TIMESPEC_TO_TIMEVAL? > > Andreas. > None in fact, I will adjust to use TIMESPEC_TO_TIMEVAL.