From: Carlos O'Donell <carlos@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: Rical Jasan <rj@2c3t.io>,
GNU C Library <libc-alpha@sourceware.org>,
Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCHv5] Add convenience target 'install-locale-files'.
Date: Thu, 02 Aug 2018 19:33:00 -0000 [thread overview]
Message-ID: <4bec52f2-90a1-b0e8-750a-87e8b6c6e92b@redhat.com> (raw)
In-Reply-To: <85bae216-5769-272b-6135-779000527a10@redhat.com>
On 07/27/2018 04:17 PM, Carlos O'Donell wrote:
> On 07/26/2018 04:30 PM, Carlos O'Donell wrote:
>> On 07/26/2018 04:25 PM, Joseph Myers wrote:
>>> On Thu, 26 Jul 2018, Carlos O'Donell wrote:
>>>
>>>> +directories e.g. @file{/usr/lib/locale/en_US.utf8}. For example to install
>>>
>>> Should have exactly one space after "e.g.", and need @: before that space
>>> for it to be properly treated as not an end-of-sentence space.
>>>
>>>> +root use @samp{DESTDIR} e.g. @samp{make localedata/install-locale-files
>>>
>>> Likewise, need @: after e.g. to avoid makeinfo treating it as the end of a
>>> sentence and inserting an extra space in INSTALL there.
>>>
>>
>> Thanks! I'd forgotten about that.
>>
>> v4
>> - Fix texinfo formatting.
>
> v5
> - Fix commit message to use DESTDIR.
>
> Final version. I'll push this when 2.29 opens if nobody objects.
Committed.
--
Cheers,
Carlos.
prev parent reply other threads:[~2018-08-02 19:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 17:27 [PATCH] " Carlos O'Donell
2018-07-26 17:33 ` Joseph Myers
2018-07-26 18:03 ` [PATCHv2] " Carlos O'Donell
2018-07-26 18:36 ` Rical Jasan
2018-07-26 20:17 ` [PATCHv3] " Carlos O'Donell
2018-07-26 20:25 ` Joseph Myers
2018-07-26 20:30 ` [PATCHv4] " Carlos O'Donell
2018-07-27 20:17 ` [PATCHv5] " Carlos O'Donell
2018-08-02 19:33 ` Carlos O'Donell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bec52f2-90a1-b0e8-750a-87e8b6c6e92b@redhat.com \
--to=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=rj@2c3t.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).