From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 2/2] Revert "linux: Move xmknod{at} to compat symbols"
Date: Fri, 23 Oct 2020 13:39:50 -0300 [thread overview]
Message-ID: <4c312536-35ee-9ed7-e231-3bac939fefa6@linaro.org> (raw)
In-Reply-To: <87tuukhpd5.fsf@oldenburg2.str.redhat.com>
On 23/10/2020 13:35, Florian Weimer wrote:
> * Adhemerval Zanella:
>
>> This reverts commit 81b83ff61f95f30ad53d6075247af0ea61a0b16e responsible
>> to make both __xmknod{at} compatible symbols.
>>
>> The idea is to not force static libraries built against old glibc
>> to update against new glibcs (since they reference the the
>> xmknod{at} symbols).
>
> I think it's not correct to label this as a revert in the Git sense.
> At best it's a partial revert. I tried first to verify this as an
> actual revert and was wondering if I got the diffing wrong.
Ok, I will change to a partial remove.
>
> I think you need to remove libc_hidden_def and libc_hidden_proto around
> __xmknod, __xmknodat. “git grep 'libc_hidden.*__xmknod'” should not
> return anything. Maybe that should be a separate patch.
If I recall correctly they are still required for Hurd, but I double
check. In fact I think we should remove all the io/*xstat* and
io/*xmknod* since there is no point in providing them as generic
interfaces.
next prev parent reply other threads:[~2020-10-23 16:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 19:03 [PATCH 1/2] Revert "linux: Move {f}xstat{at} " Adhemerval Zanella
2020-10-22 19:03 ` [PATCH 2/2] Revert "linux: Move xmknod{at} " Adhemerval Zanella
2020-10-23 16:35 ` Florian Weimer
2020-10-23 16:39 ` Adhemerval Zanella [this message]
2020-10-23 16:43 ` Florian Weimer
2020-10-23 16:47 ` Adhemerval Zanella
2020-10-23 17:18 ` Florian Weimer
2020-10-23 18:56 ` Adhemerval Zanella
2020-10-26 12:56 ` Florian Weimer
2020-10-26 16:24 ` Adhemerval Zanella
2020-10-26 16:30 ` Florian Weimer
2020-12-02 1:45 ` Siddhesh Poyarekar
2020-12-02 11:32 ` Adhemerval Zanella
2020-12-24 11:51 ` [PATCH 1/2] Revert "linux: Move {f}xstat{at} " Andreas Schwab
2020-12-24 12:11 ` Florian Weimer
2020-12-24 12:32 ` Andreas Schwab
2020-12-24 13:11 ` Adhemerval Zanella
2020-12-24 14:28 ` Florian Weimer
2020-12-24 14:48 ` Adhemerval Zanella
2020-12-24 15:21 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c312536-35ee-9ed7-e231-3bac939fefa6@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).