From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id 67CAE3857B93 for ; Wed, 27 Sep 2023 13:42:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 67CAE3857B93 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-690bfd4f3ebso8675450b3a.3 for ; Wed, 27 Sep 2023 06:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695822126; x=1696426926; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=Y5ck1VJASQ4iny3Yv2tgl6QwPevb2XBeAo7ODYadJrA=; b=uDsPTg44zgonYAbzfT0HFYmnNAYTHWuv1mH/vTt5SsrVewUePndf2v+4rS/VGUBdIB ISe9ISvzOf65R57UsVURRB1bW6ulvMXlIf1OMbULROAiiu3WOBkghwkaJv618GSkaw1x /cT9pT6KwMI6rx+Ba1p+A9mhE0GlExywIb8Tv7OENgVcmm7UyYFptAZgsRB78qypqkTb pp7nB9hmkGUCWmnUeg+EZ5JhWRKNH//Cfbl14WHWInmebNV5ZR0uHzZGWjImzSmP6EPk ZifPYNkF+InKMjn/QgXekOp8bDr+veQMFh4MlonKsxW0XOvGVCyGC6O+rAwdptGktIY1 /W+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695822126; x=1696426926; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Y5ck1VJASQ4iny3Yv2tgl6QwPevb2XBeAo7ODYadJrA=; b=NMqY8FD+plPxVo9w6Zdwlsdd1wkBW2Rw1gFrX1cGIWb5/prMYQX/y5Zi6DTUNT9GkU 2RIXjMVYUIIt/xg+rkMyWokdYI5fGVuaf/6k2DJjj3r+1YfjuZ291d4ror4qps///yoe 9I7N79PfooqArXsQSWZN0HGPhePun7sGRLAMfPpXawJNz83EqSYGsl3UJmeSqOW4uRua qFp9nGvGxxE9nODkQNoCeIU53O3uKdAtf5PnMSavtgFGt1b+Dzyqut5h9c+QEq2frwOZ 7quvabwpwwkWiE97LS5UkQUe6fnTm8CjN3OAm2QbH5zSu8t+hahVyh5RKKq4QjKlded5 mkaw== X-Gm-Message-State: AOJu0YxCVDUzXf5SgYCiwGCFe3NyhTnUEYr7HQhpVPUTfsaFKrNr4cLd JV+MrnCCOzNWZASRqt0wTzOwlxokvwjuGG/FIZJD4Q== X-Google-Smtp-Source: AGHT+IEXgf3OKJ6L0RHWSX7jABwDlo2cAjSkFeCziq7plP3k6ONQvyaeHcpTQZd1D859TY5u6c6sYQ== X-Received: by 2002:a05:6a21:1f07:b0:15d:5f9a:391c with SMTP id ry7-20020a056a211f0700b0015d5f9a391cmr1579631pzb.33.1695822126349; Wed, 27 Sep 2023 06:42:06 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c1:6eb0:6d4f:92fe:5e4e:27d3? ([2804:1b3:a7c1:6eb0:6d4f:92fe:5e4e:27d3]) by smtp.gmail.com with ESMTPSA id c14-20020aa7880e000000b0069100e70943sm11765298pfo.24.2023.09.27.06.42.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Sep 2023 06:42:05 -0700 (PDT) Message-ID: <4c4b72fe-e3ae-447c-9f64-064f44012327@linaro.org> Date: Wed, 27 Sep 2023 10:42:02 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 1/3] MIPS: Add ELF file header flags To: Ying Huang Cc: Libc-alpha References: <20230831032302.3736352-1-ying.huang@oss.cipunited.com> <20230831032302.3736352-2-ying.huang@oss.cipunited.com> Content-Language: en-US From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I will commit this patchset on your behalf. On 21/09/23 23:52, Ying Huang wrote: > Hi, > > I did not have commit rights, could you hep commit? > > Thanks, > > Ying > > > 在 2023/9/21 14:47, Adhemerval Zanella Netto 写道: >> >> On 31/08/23 00:22, Ying Huang wrote: >>> From: Ying Huang >>> >>> Now binutils use some E_MIPS_* macros and EF_MIPS_* macros, it is >>> difficult to decide which style macro we should use when we want >>> to add new ELF file header flags. >>> IRIX used to use EF_MIPS_* macros and in elf/elf.h there also has >>> comments "The following are unofficial names and should not be used". >>> So we should use EF_MIPS_* to keep same style with the beginning. >> It does not trigger any build/check regression and it seems to be >> in sync with binutils, so it should be ok. >> >>> --- >>> elf/elf.h | 48 +++++++++++++++++++++++++++++++++++++++++++++++- >>> 1 file changed, 47 insertions(+), 1 deletion(-) >>> >>> diff --git a/elf/elf.h b/elf/elf.h >>> index 9c51073f75..43657f6b46 100644 >>> --- a/elf/elf.h >>> +++ b/elf/elf.h >>> @@ -1685,11 +1685,25 @@ typedef struct >>> #define EF_MIPS_PIC 2 /* Contains PIC code. */ >>> #define EF_MIPS_CPIC 4 /* Uses PIC calling sequence. */ >>> #define EF_MIPS_XGOT 8 >>> -#define EF_MIPS_64BIT_WHIRL 16 >>> +#define EF_MIPS_UCODE 16 >>> #define EF_MIPS_ABI2 32 >>> #define EF_MIPS_ABI_ON32 64 >>> +#define EF_MIPS_OPTIONS_FIRST 0x00000080 /* Process the .MIPS.options >>> + section first by ld. */ >>> +#define EF_MIPS_32BITMODE 0x00000100 /* Indicates code compiled for >>> + a 64-bit machine in 32-bit >>> + mode (regs are 32-bits >>> + wide). */ >>> #define EF_MIPS_FP64 512 /* Uses FP64 (12 callee-saved). */ >>> #define EF_MIPS_NAN2008 1024 /* Uses IEEE 754-2008 NaN encoding. */ >>> +#define EF_MIPS_ARCH_ASE 0x0f000000 /* Architectural Extensions >>> + used by this file. */ >>> +#define EF_MIPS_ARCH_ASE_MDMX 0x08000000 /* Use MDMX multimedia >>> + extensions. */ >>> +#define EF_MIPS_ARCH_ASE_M16 0x04000000 /* Use MIPS-16 ISA >>> + extensions. */ >>> +#define EF_MIPS_ARCH_ASE_MICROMIPS 0x02000000 /* Use MICROMIPS ISA >>> + extensions. */ >>> #define EF_MIPS_ARCH 0xf0000000 /* MIPS architecture level. */ >>> >>> /* Legal values for MIPS architecture level. */ >>> @@ -1703,6 +1717,38 @@ typedef struct >>> #define EF_MIPS_ARCH_64 0x60000000 /* MIPS64 code. */ >>> #define EF_MIPS_ARCH_32R2 0x70000000 /* MIPS32r2 code. */ >>> #define EF_MIPS_ARCH_64R2 0x80000000 /* MIPS64r2 code. */ >>> +#define EF_MIPS_ARCH_32R6 0x90000000 /* MIPS32r6 code. */ >>> +#define EF_MIPS_ARCH_64R6 0xa0000000 /* MIPS64r6 code. */ >>> +#define EF_MIPS_ABI 0x0000F000 /* The ABI of the file. Also >>> + see EF_MIPS_ABI2 above. */ >>> +#define EF_MIPS_ABI_O32 0x00001000 /* The original o32 abi. */ >>> +#define EF_MIPS_ABI_O64 0x00002000 /* O32 extended to work on >>> + 64 bit architectures. */ >>> +#define EF_MIPS_ABI_EABI32 0x00003000 /* EABI in 32 bit mode. */ >>> +#define EF_MIPS_ABI_EABI64 0x00004000 /* EABI in 64 bit mode. */ >>> +#define EF_MIPS_MACH 0x00FF0000 >>> +#define EF_MIPS_MACH_3900 0x00810000 >>> +#define EF_MIPS_MACH_4010 0x00820000 >>> +#define EF_MIPS_MACH_4100 0x00830000 >>> +#define EF_MIPS_MACH_ALLEGREX 0x00840000 >>> +#define EF_MIPS_MACH_4650 0x00850000 >>> +#define EF_MIPS_MACH_4120 0x00870000 >>> +#define EF_MIPS_MACH_4111 0x00880000 >>> +#define EF_MIPS_MACH_SB1 0x008a0000 >>> +#define EF_MIPS_MACH_OCTEON 0x008b0000 >>> +#define EF_MIPS_MACH_XLR 0x008c0000 >>> +#define EF_MIPS_MACH_OCTEON2 0x008d0000 >>> +#define EF_MIPS_MACH_OCTEON3 0x008e0000 >>> +#define EF_MIPS_MACH_5400 0x00910000 >>> +#define EF_MIPS_MACH_5900 0x00920000 >>> +#define EF_MIPS_MACH_IAMR2 0x00930000 >>> +#define EF_MIPS_MACH_5500 0x00980000 >>> +#define EF_MIPS_MACH_9000 0x00990000 >>> +#define EF_MIPS_MACH_LS2E 0x00A00000 >>> +#define EF_MIPS_MACH_LS2F 0x00A10000 >>> +#define EF_MIPS_MACH_GS464 0x00A20000 >>> +#define EF_MIPS_MACH_GS464E 0x00A30000 >>> +#define EF_MIPS_MACH_GS264E 0x00A40000 >>> >>> /* The following are unofficial names and should not be used. */ >>> >