From: Peter Bergner <bergner@vnet.ibm.com>
To: Rajalakshmi Srinivasaraghavan <raji@linux.vnet.ibm.com>,
libc-alpha@sourceware.org
Subject: Re: [PATCH] powerpc64: strrchr optimization for power8
Date: Mon, 13 Feb 2017 16:18:00 -0000 [thread overview]
Message-ID: <4c4e0dfa-793f-bb20-0ce6-d1c4d1c2c257@vnet.ibm.com> (raw)
In-Reply-To: <1486616454-14704-1-git-send-email-raji@linux.vnet.ibm.com>
On 2/8/17 11:00 PM, Rajalakshmi Srinivasaraghavan wrote:
> + /* r4 is changed now ,if its passed as more chars
> + check for null again */
Not sure without looking at the code closer, but should this
read like the following???
/* r4 is changed now. If it's passed more chars, then check for
null again. */
> + /* if there are more than one 0xff in r11, find the first pos of ff
> + in r11 and fill r10 with 0 from that position */
First word should be capitalized and there is no final '.' and two
spaces at the end of the sentence. I would also write out position
rather than using "pos" like you did at the end of the sentence.
> + vsl v9, v8, v9 /* v9 = 0x4040404040404040. */
Two spaces after the '.'.
Peter
next prev parent reply other threads:[~2017-02-13 16:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 5:01 Rajalakshmi Srinivasaraghavan
2017-02-09 15:26 ` Gabriel F. T. Gomes
2017-02-13 16:18 ` Peter Bergner [this message]
2017-02-14 11:06 Rajalakshmi Srinivasaraghavan
2017-02-20 13:10 ` Gabriel F. T. Gomes
2017-02-20 13:43 ` Carlos O'Donell
2017-02-20 16:01 ` Rajalakshmi Srinivasaraghavan
2017-02-20 16:06 ` Carlos O'Donell
2017-02-20 16:50 ` Rajalakshmi Srinivasaraghavan
2017-02-28 7:32 ` Rajalakshmi Srinivasaraghavan
2017-03-09 6:14 ` Rajalakshmi Srinivasaraghavan
2017-03-17 15:38 ` Carlos O'Donell
2017-03-20 8:39 ` Rajalakshmi Srinivasaraghavan
2017-03-20 16:34 ` Carlos O'Donell
2017-03-21 5:15 ` Rajalakshmi Srinivasaraghavan
2017-04-03 15:30 ` Tulio Magno Quites Machado Filho
2017-04-17 15:20 ` Carlos O'Donell
2017-02-21 17:02 ` Carlos Eduardo Seo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c4e0dfa-793f-bb20-0ce6-d1c4d1c2c257@vnet.ibm.com \
--to=bergner@vnet.ibm.com \
--cc=libc-alpha@sourceware.org \
--cc=raji@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).