From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-69857-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 76885 invoked by alias); 25 May 2016 09:02:18 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 76425 invoked by uid 89); 25 May 2016 09:02:17 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:400, Hx-spam-relays-external:sk:dhcp-19, H*RU:sk:dhcp-19
X-HELO: mx1.redhat.com
Subject: Re: [PATCH 1/3] Optimize trunc() and truncf().
To: Matt Turner <mattst88@gmail.com>, libc-alpha@sourceware.org
References: <1464139950-31943-1-git-send-email-mattst88@gmail.com>
Cc: Joseph Myers <joseph@codesourcery.com>
From: Florian Weimer <fweimer@redhat.com>
Message-ID: <4c79311f-f1f7-2202-e13e-e6ff6cde87f7@redhat.com>
Date: Wed, 25 May 2016 10:39:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.0
MIME-Version: 1.0
In-Reply-To: <1464139950-31943-1-git-send-email-mattst88@gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-05/txt/msg00573.txt.bz2

On 05/25/2016 03:32 AM, Matt Turner wrote:
 > +  int64_t exp = (i0 >> 52) & 0x7ff;
 > +  int64_t mask = UINT64_C(-1) << max(52 - (exp - 1023), 0);

I think it will help GCC if you make exp an int and change the max 
function accordingly.

You should use spaces in front of the parenthesis in a function call, 
and also for most macro calls.

Thanks,
Florian