From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc2b.google.com (mail-oo1-xc2b.google.com [IPv6:2607:f8b0:4864:20::c2b]) by sourceware.org (Postfix) with ESMTPS id 089513858D28 for ; Wed, 9 Feb 2022 12:15:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 089513858D28 Received: by mail-oo1-xc2b.google.com with SMTP id p190-20020a4a2fc7000000b0031820de484aso2146278oop.9 for ; Wed, 09 Feb 2022 04:15:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:references:in-reply-to :content-transfer-encoding; bh=Ybs4fnxRZs10IFt89/afDVXQqzkRhXMzcL8UTWKq9pQ=; b=AGLHP5FLIntfNbBPwdAmOK0mfm6YakCLB0hgGSf9VtifXqa5TPQFoZBVnQ+WCdit/4 uPtDmYj96RMRmWYjxFm1TXP+Z7lNkCyd1tFGynTpX1j0fxuADdH+YxDfsk2pUTfbkySg YoNq66fQgVVzeBP2RRZI9WyY8pZtD/+fWZauBBU/O6a0Niwda5I4IvJH0YLCL9D3JsLT uBJFU1nH1e+GtAGEdIS9jj9VcOHNTb2OMe/9o8klVbJDWsOM3ZLaElTQ0ey2g9jUORv+ 4F4WnF3lTwr/KzyF0BjcrO8alraOwlJrRAhwZXwJBiP3ZOBstxFmVx6JegcbM5o8XLgq f7bA== X-Gm-Message-State: AOAM533u4a5viKYmbGimdJSXzq9zxR9ldzixJZHGlBenFnqAzsNDv3hu Ox7l+mGyyRCpHbmTDbLuYdNJRnmCQwhsgg== X-Google-Smtp-Source: ABdhPJxmzxlEwSzLZOZBaDTYKQKnNhaU0+5wzMN9wlvA00ZAv2FKyupe4XQmgt8BpOxJzm4y8T4mOg== X-Received: by 2002:a4a:b401:: with SMTP id y1mr754771oon.95.1644408903254; Wed, 09 Feb 2022 04:15:03 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:733:620:153c:dcac:6440? ([2804:431:c7ca:733:620:153c:dcac:6440]) by smtp.gmail.com with ESMTPSA id p22sm7572579oae.33.2022.02.09.04.15.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Feb 2022 04:15:02 -0800 (PST) Message-ID: <4d02dd5e-0a29-eef0-3ed3-21e16b322d24@linaro.org> Date: Wed, 9 Feb 2022 09:15:00 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH] elf: Fix DFS sorting algorithm for LD_TRACE_LOADED_OBJECTS with missing libraries (BZ #28868) Content-Language: en-US From: Adhemerval Zanella To: "Dmitry V. Levin" , libc-alpha@sourceware.org References: <20220208183639.2262680-1-adhemerval.zanella@linaro.org> <20220208224838.GB21338@altlinux.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Feb 2022 12:15:05 -0000 On 08/02/2022 19:56, Adhemerval Zanella wrote: > > > On 08/02/2022 19:48, Dmitry V. Levin wrote: >> On Tue, Feb 08, 2022 at 03:36:39PM -0300, Adhemerval Zanella via Libc-alpha wrote: >> [...] >>> diff --git a/elf/libtracemod1.c b/elf/libtracemod1.c >>> new file mode 100644 >>> index 0000000000..7c89c9a5a4 >>> --- /dev/null >>> +++ b/elf/libtracemod1.c >>> @@ -0,0 +1 @@ >>> +/* Empty */ >>> diff --git a/elf/libtracemod2.c b/elf/libtracemod2.c >>> new file mode 100644 >>> index 0000000000..7c89c9a5a4 >>> --- /dev/null >>> +++ b/elf/libtracemod2.c >>> @@ -0,0 +1 @@ >>> +/* Empty */ >>> diff --git a/elf/libtracemod3.c b/elf/libtracemod3.c >>> new file mode 100644 >>> index 0000000000..7c89c9a5a4 >>> --- /dev/null >>> +++ b/elf/libtracemod3.c >>> @@ -0,0 +1 @@ >>> +/* Empty */ >>> diff --git a/elf/libtracemod4.c b/elf/libtracemod4.c >>> new file mode 100644 >>> index 0000000000..7c89c9a5a4 >>> --- /dev/null >>> +++ b/elf/libtracemod4.c >>> @@ -0,0 +1 @@ >>> +/* Empty */ >>> diff --git a/elf/libtracemod5.c b/elf/libtracemod5.c >>> new file mode 100644 >>> index 0000000000..7c89c9a5a4 >>> --- /dev/null >>> +++ b/elf/libtracemod5.c >>> @@ -0,0 +1 @@ >>> +/* Empty */ >>> diff --git a/elf/libtracemod6.c b/elf/libtracemod6.c >>> new file mode 100644 >>> index 0000000000..7c89c9a5a4 >>> --- /dev/null >>> +++ b/elf/libtracemod6.c >>> @@ -0,0 +1 @@ >>> +/* Empty */ >> >> I wonder why do you need these empty files. >> >> In the reproducer included in the bug report empty shared libraries >> are created without any input files at all: >> >> $ gcc -shared -o missing/libmissing1.so -Wl,-soname,libmissing1.so >> $ gcc -shared -o missing/libmissing2.so -Wl,-soname,libmissing2.so > > Maybe because without a file it would require more Makefile tinkering to I meant 'Mainly' here, I did not want to sound pedantic here. > add specific rules to build the modules. Not sure if this would really > be simpler than add the files.