From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Alejandro Colomar <colomar.6.4.3@gmail.com>
Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org,
libc-alpha@sourceware.org
Subject: Re: [PATCH 1/4] system_data_types.7: wfix
Date: Fri, 18 Sep 2020 22:27:50 +0200 [thread overview]
Message-ID: <4d201c89-8c47-8487-3672-b9af39c1bf2d@gmail.com> (raw)
In-Reply-To: <20200918124554.46308-2-colomar.6.4.3@gmail.com>
Hello Alex,
On 9/18/20 2:45 PM, Alejandro Colomar wrote:
> Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>
> ---
> man7/system_data_types.7 | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/man7/system_data_types.7 b/man7/system_data_types.7
> index dba80cf6f..8969ee966 100644
> --- a/man7/system_data_types.7
> +++ b/man7/system_data_types.7
> @@ -350,7 +350,7 @@ struct timespec {
> };
> .EE
> .IP
> -Describes times in seconds and nanoseconds.
> +Describes elapsed time in seconds and nanoseconds.
> .IP
> Conforming to: C11 and later; POSIX.1-2001 and later.
> .IP
> @@ -379,7 +379,7 @@ struct timeval {
> };
> .EE
> .IP
> -Describes times in seconds and microseconds.
> +Describes elapsed time in seconds and microseconds.
> .IP
> Conforming to: POSIX.1-2001 and later.
> .IP
I don;t think this patch is correct. At the least, it needs
more explanation. As far as I can see, 'timespec' is not just
about elapsed time. It really is just time, expressed as secs +
nanosecs. For example, see utimensat(2), which set file timestamps
with nanosec precision.
For the moment, I'm not applying this (and I hope not doing so
doesn't break any following patch).
Thanks,
Michael
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
next prev parent reply other threads:[~2020-09-18 20:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 12:45 [PATCH 0/4] Document regoff_t (and a few minor patches) Alejandro Colomar
2020-09-18 12:45 ` [PATCH 1/4] system_data_types.7: wfix Alejandro Colomar
2020-09-18 20:27 ` Michael Kerrisk (man-pages) [this message]
2020-09-18 21:32 ` Alejandro Colomar
2020-09-18 12:45 ` [PATCH 2/4] system_data_types.7: Document regoff_t Alejandro Colomar
2020-09-18 20:30 ` Michael Kerrisk (man-pages)
2020-09-18 12:45 ` [PATCH 3/4] regoff_t.3: New link to new documented type in system_data_types(7) Alejandro Colomar
2020-09-18 20:31 ` Michael Kerrisk (man-pages)
2020-09-18 12:45 ` [PATCH 4/4] system_data_types.7: srcfix: Add FIXME notes Alejandro Colomar
2020-09-18 20:32 ` Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d201c89-8c47-8487-3672-b9af39c1bf2d@gmail.com \
--to=mtk.manpages@gmail.com \
--cc=colomar.6.4.3@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-man@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).