Hi Florian,

在 2023/8/8 00:30, Florian Weimer 写道:
> * Ying Huang:
>
>> From: Ying Huang <ying.huang@oss.cipunited.com>
>>
>> Add new definitions for the MIPS target, specifically: relocation
>> types, machine flags, section type names, and object attribute tags
>> and values.  On MIPS64, up to three relocations may be specified
>> within r_info, by the r_type, r_type2, and r_type3 fields, so add new
>> macros to get the respective reloc types for MIPS64.
> Sorry, it's a bit of a mystery against what exactly you are syncing.
> Current binutils has E_MIPS_MACH_ALLEGREX, which you are not adding.  On
> the other hand, binutils lacks EF_MIPS_ARCH_32R6, which your patch adds.
> (These are just two illustrative examples.)
>
> At least from the glibc side, this now looks okay, it's just about
> documenting where the constants come from.
>
> Thanks,
> Florian


The macro E_MIPS_MACH_ALLEGREX was added at Jun 15 2023, sorry I forgot to confirm whether it update.

I would add and update the commit messange.

See mail: Re: [PATCH v4] MIPS: Sync elf.h from binutils

/在 2023/6/5 01:02, Maciej W. Rozycki 写道:/
//
> /@@ -1703,6 +1713,35 @@ typedef struct #define EF_MIPS_ARCH_64 0x60000000 /* MIPS64 code. */ #define EF_MIPS_ARCH_32R2 0x70000000 /* MIPS32r2 code. */ #define EF_MIPS_ARCH_64R2 0x80000000 /* MIPS64r2 code. */ +#define E_MIPS_ARCH_32R6 0x90000000 /* -mips32r6 code. */ +#define E_MIPS_ARCH_64R6 0xa0000000 /* -mips64r6 code. */ /
//

/I think all new additions are supposed to start with EF_ rather than E_. IIUC the existence of E_ macros has something to do with the old SVR4 ABI registry maintained by SCO long ago: you could only add new EF_ macros once they've been registered with SCO (someone please correct me if I'm wrong). Also I think the new comments will best be spelt MIPS32r6/MIPS64r6 rather than -mips32r6/-mips64r6 for consistency with MIPS32r2/MIPS64r2 above. /
After this advice, I changed E_ to EF_ and change the related comments.

Thanks,
Ying