From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from t03.bc.larksuite.com (t03.bc.larksuite.com [209.127.231.36]) by sourceware.org (Postfix) with UTF8SMTPS id 44A093858D33 for ; Tue, 8 Aug 2023 03:36:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 44A093858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=oss.cipunited.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oss.cipunited.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=feishu2303200042; d=oss.cipunited.com; t=1691465789; h=from:subject:mime-version:from:date:message-id:subject:to:cc: reply-to:content-type:mime-version:in-reply-to:message-id; bh=DdpNHVIy8LobX5d1Rh2aFOfq1a2+xP4CLK8f3gZ1tSo=; b=MxudQybQTqRcUAa90TBZelL3Ey5TLRkX6b+WFIm/E17LgWMVTF1WO1wNsSc6XsAep8EvR3 /m1U8l298srp8uPaxtV9cg2L3k/eNooucnjNgQkObTg7XHHRTHyH1QG5he4dsqMh1as0ve +7Qrlcf+CSEvAnYjQ4CeW91yNsg+YWQOpJMk36GACE1eZpMs2gtnGkq7m5kk8CCuMp54D5 XcI5UpbmpU4SPnyVTreA8MfosOHL85Af66Rmgpw84z6hXhsjnkA0Avk8OA9sSv42nwxa6g bIvw626LxbYJjxfbLlC4fakBdqpd/fuvk4wxOMPit3eb4PNBVBkWRpqAHqwjOw== From: "Ying Huang" Content-Language: en-US To: "Florian Weimer" X-Lms-Return-Path: Subject: Re: [PATCH v7] MIPS: Sync elf.h from binutils References: <20230807020524.2031213-1-ying.huang@oss.cipunited.com> <87leemerwd.fsf@oldenburg.str.redhat.com> Mime-Version: 1.0 Date: Tue, 8 Aug 2023 11:36:26 +0800 Message-Id: <4d3d1518-364c-8374-9d3d-86d1afe25d62@oss.cipunited.com> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 In-Reply-To: <87leemerwd.fsf@oldenburg.str.redhat.com> X-Original-From: Ying Huang Content-Transfer-Encoding: 8bit Content-Type: multipart/alternative; boundary=f7c964685d68b7ab7564c5394df370b9c37a3fc8b226e188a7acce3365c8 Cc: "libc-alpha" , X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HTML_MESSAGE,HTML_NONELEMENT_30_40,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --f7c964685d68b7ab7564c5394df370b9c37a3fc8b226e188a7acce3365c8 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Hi Florian, =E5=9C=A8 2023/8/8 00:30, Florian Weimer =E5=86=99=E9=81=93: > * Ying Huang: > >> From: Ying Huang >> >> Add new definitions for the MIPS target, specifically: relocation >> types, machine flags, section type names, and object attribute tags >> and values. On MIPS64, up to three relocations may be specified >> within r_info, by the r_type, r_type2, and r_type3 fields, so add new >> macros to get the respective reloc types for MIPS64. > Sorry, it's a bit of a mystery against what exactly you are syncing. > Current binutils has E_MIPS_MACH_ALLEGREX, which you are not adding. On > the other hand, binutils lacks EF_MIPS_ARCH_32R6, which your patch adds. > (These are just two illustrative examples.) > > At least from the glibc side, this now looks okay, it's just about > documenting where the constants come from. > > Thanks, > Florian The macro E_MIPS_MACH_ALLEGREX was added at Jun 15 2023, sorry I forgot to = confirm whether it update. I would add and update the commit messange. See mail: Re: [PATCH v4] MIPS: Sync elf.h from binutils /=E5=9C=A8 2023/6/5 01:02, Maciej W. Rozycki =E5=86=99=E9=81=93:/ // > /@@ -1703,6 +1713,35 @@ typedef struct #define EF_MIPS_ARCH_64 0x60000000= /* MIPS64 code. */ #define EF_MIPS_ARCH_32R2 0x70000000 /* MIPS32r2 code. = */ #define EF_MIPS_ARCH_64R2 0x80000000 /* MIPS64r2 code. */ +#define E_MIP= S_ARCH_32R6 0x90000000 /* -mips32r6 code. */ +#define E_MIPS_ARCH_64R6 0xa0= 000000 /* -mips64r6 code. */ / // /I think all new additions are supposed to start with EF_ rather than E_. I= IUC the existence of E_ macros has something to do with the old SVR4 ABI re= gistry maintained by SCO long ago: you could only add new EF_ macros once t= hey've been registered with SCO (someone please correct me if I'm wrong). A= lso I think the new comments will best be spelt MIPS32r6/MIPS64r6 rather th= an -mips32r6/-mips64r6 for consistency with MIPS32r2/MIPS64r2 above. / After this advice, I changed E_ to EF_ and change the related comments. Thanks, Ying= --f7c964685d68b7ab7564c5394df370b9c37a3fc8b226e188a7acce3365c8--