From: Florian Weimer <fweimer@redhat.com>
To: Andreas Schwab <schwab@suse.de>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] manual: Result of mbrtowc is a single wide character
Date: Thu, 05 Apr 2018 09:51:00 -0000 [thread overview]
Message-ID: <4d4ab928-cb26-9be4-d53e-ca3573f96265@redhat.com> (raw)
In-Reply-To: <mvmy3i32gt1.fsf@suse.de>
On 04/04/2018 04:21 PM, Andreas Schwab wrote:
> On Apr 04 2018, fweimer@redhat.com (Florian Weimer) wrote:
>
>> diff --git a/manual/examples/mbstouwcs.c b/manual/examples/mbstouwcs.c
>> index 5d223da2ae..3a8b9a65f9 100644
>> --- a/manual/examples/mbstouwcs.c
>> +++ b/manual/examples/mbstouwcs.c
>> @@ -20,7 +20,7 @@ mbstouwcs (const char *s)
>> if (nbytes >= (size_t) -2)
>> /* Invalid input string. */
>> return NULL;
>> - *wcp++ = towupper (tmp[0]);
>> + *wcp++ = towupper (*tmp);
>
> tmp is declared as an array, so tmp[0] is more natural.
Thanks. I'm going to fold this change into the other patch.
Florian
prev parent reply other threads:[~2018-04-05 9:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 13:57 Florian Weimer
2018-04-04 14:21 ` Andreas Schwab
2018-04-05 9:51 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d4ab928-cb26-9be4-d53e-ca3573f96265@redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).