From: caiyinyu <caiyinyu@loongson.cn>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org, adhemerval.zanella@linaro.org,
xry111@xry111.site, lixing@loongson.cn
Subject: Re: [PATCH] LoongArch: Fix inconsistency in SHMLBA macro values between glibc and kernel
Date: Thu, 25 May 2023 19:09:44 +0800 [thread overview]
Message-ID: <4db2f272-d30e-b571-268a-9abcb3050c5e@loongson.cn> (raw)
In-Reply-To: <87zg5sllnj.fsf@oldenburg.str.redhat.com>
在 2023/5/25 下午7:01, Florian Weimer 写道:
>> The LoongArch glibc was using the value of the SHMLBA macro from common code,
>> which is __getpagesize() (16k), but this was inconsistent with the value of
>> the SHMLBA macro in the kernel, which is SZ_64K (64k). This caused several
>> shmat-related tests in LTP (Linux Test Project) to fail. This commit fixes
>> the issue by ensuring that the glibc's SHMLBA macro value matches the value
>> used in the kernel like other architectures.
> Would it be possible to add a generic test like
> sysdeps/unix/sysv/linux/tst-mman-consts.py against the UAPI headers?
> Or is this constant not exported at all?
The Linux kernel defines the architecture-dependent macro SHMLBA in
arch/*/include/asm/shmparam.h.
This macro is also defined in the common code in
include/asm-generic/shmparam.h.
However, neither of them are exported as part of the uapi.
>
> Thanks,
> Florian
prev parent reply other threads:[~2023-05-25 11:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 10:32 caiyinyu
2023-05-25 11:01 ` Florian Weimer
2023-05-25 11:05 ` Xi Ruoyao
2023-05-25 11:09 ` caiyinyu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4db2f272-d30e-b571-268a-9abcb3050c5e@loongson.cn \
--to=caiyinyu@loongson.cn \
--cc=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=lixing@loongson.cn \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).