From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) by sourceware.org (Postfix) with ESMTPS id 5A4BD3858D28 for ; Wed, 29 Dec 2021 15:06:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5A4BD3858D28 Received: by mail-qt1-x836.google.com with SMTP id j17so19156820qtx.2 for ; Wed, 29 Dec 2021 07:06:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=O1TClxI7x78GcW9fUXeHAdmpsNMW9hCyNyfsjlnYL34=; b=Sd2BD9TbfW7YR1nTsjTMck0J9X6p0mtqmaLUtZRWYfMfeq//ae5YnNJn8PnKV//1HI HSNixBTMMth0fxVzRWhaO7dn2syXv6Y1w4zEep7+2zxrA1R/NHtBAxlgg4iuB+5b/9Cc kVXReBWXcKl4YTBNwTEQa4yBPkV15J834oOkTCnDqKCQE2TmSJJ6rTtBrr04TzqnCHWU /ZqlM2SNGgQPumsyw7a1P9XPm5DY4TwDUUlY3djJKHpf+TKTzvMNGhlG8B/loj15+y9d vXWK+BjqncWdygl9lmHzfxrHBQNXiATOsY10fXvdGNaGsktX2OjDKWEpnBZwnr0MN8fV j6KQ== X-Gm-Message-State: AOAM5311de5hlprbNPY7MT3yBVSrcI6BzCP4U5eYSiQGKlU/OyNvOtm+ RTFGP/77uR9nv7IqEF5OA3bpUA== X-Google-Smtp-Source: ABdhPJzRzKWHbncHhMzv11agD5LvxJM5SzDQRr1ZVgZEu56Knr5ooBRWP8R7BeBewsMgj4joIKJgZg== X-Received: by 2002:a05:622a:8a:: with SMTP id o10mr22752444qtw.178.1640790378908; Wed, 29 Dec 2021 07:06:18 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:a350:349e:1fa8:ba3d:5b36? ([2804:431:c7ca:a350:349e:1fa8:ba3d:5b36]) by smtp.gmail.com with ESMTPSA id y14sm12882140qkp.27.2021.12.29.07.06.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Dec 2021 07:06:18 -0800 (PST) Message-ID: <4dc569a4-8380-a772-f5c1-b4be824c629a@linaro.org> Date: Wed, 29 Dec 2021 12:06:16 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH] elf: Fix 64 time_t support for installed statically binaries Content-Language: en-US To: Andreas Schwab , Adhemerval Zanella via Libc-alpha Cc: Florian Weimer References: <20211229132711.3324972-1-adhemerval.zanella@linaro.org> <87y243jwgn.fsf@igel.home> From: Adhemerval Zanella In-Reply-To: <87y243jwgn.fsf@igel.home> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Dec 2021 15:06:27 -0000 On 29/12/2021 11:51, Andreas Schwab wrote: > On Dez 29 2021, Adhemerval Zanella via Libc-alpha wrote: > >> The usage of internal static symbol for statically linked binaries >> does not work correctly for objects built with -D_TIME_BITS=64, >> since the internal definition does not provide the expected aliases. > > What is the expected alias and why is it not provided? If stat64 does > not provide the correct interface, this looks like a bug. > The stat64 does provide the correct 64 time_t alias and the change is not strictly required, I did it just to always use the default interface.