From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from crocodile.elm.relay.mailchannels.net (crocodile.elm.relay.mailchannels.net [23.83.212.45]) by sourceware.org (Postfix) with ESMTPS id 1DEE33898509 for ; Mon, 28 Jun 2021 04:45:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1DEE33898509 X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 9DF2178154C; Mon, 28 Jun 2021 04:45:51 +0000 (UTC) Received: from pdx1-sub0-mail-a39.g.dreamhost.com (100-96-18-98.trex.outbound.svc.cluster.local [100.96.18.98]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 33880781A7D; Mon, 28 Jun 2021 04:45:51 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a39.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.18.98 (trex/6.3.3); Mon, 28 Jun 2021 04:45:51 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Bottle-Broad: 525bff8163690986_1624855551428_1468805840 X-MC-Loop-Signature: 1624855551428:2984267129 X-MC-Ingress-Time: 1624855551427 Received: from pdx1-sub0-mail-a39.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a39.g.dreamhost.com (Postfix) with ESMTP id E92FC7F453; Sun, 27 Jun 2021 21:45:50 -0700 (PDT) Received: from [192.168.1.136] (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a39.g.dreamhost.com (Postfix) with ESMTPSA id 8264F7F455; Sun, 27 Jun 2021 21:45:48 -0700 (PDT) Subject: Re: [PATCH] Move tst-resolv-res_init-multi to xtests To: Florian Weimer , Siddhesh Poyarekar via Libc-alpha References: <20210622044449.4091104-1-siddhesh@sourceware.org> <87lf6uzjrp.fsf@oldenburg.str.redhat.com> X-DH-BACKEND: pdx1-sub0-mail-a39 From: Siddhesh Poyarekar Message-ID: <4e029cf5-c543-3982-dfab-17a51fc2c510@sourceware.org> Date: Mon, 28 Jun 2021 10:15:44 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <87lf6uzjrp.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3486.7 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jun 2021 04:45:54 -0000 On 6/28/21 10:08 AM, Florian Weimer via Libc-alpha wrote: > * Siddhesh Poyarekar via Libc-alpha: > >> Tests that need network access may cause false failures due to network >> glitches because of which they are typically added as xtests. See for >> example posix/tst-getaddrinfo{4,5}.c. Move tst-resolv-res_init-multi >> also to xtests so that it is not executed in a regular test run. > > The comment in the test says that it does not matter whether the lookup > succeeds. If this test fails, this could point to a real problem. Ahh, I should have recorded what the failure was; I don't remember it anymore. It turned up when my network went down in the middle of a `make check` run. Siddhesh