From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68257 invoked by alias); 10 Jan 2020 16:00:41 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 68193 invoked by uid 89); 10 Jan 2020 16:00:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=H*Ad:U*siddhesh, H*r:sk:siddhes, HX-Spam-Relays-External:100.96.86.180, H*RU:100.96.86.180 X-HELO: bumble.birch.relay.mailchannels.net X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Share-Cure: 26708d085914c6d9_1578672034820_1878291789 X-MC-Loop-Signature: 1578672034820:2564777820 X-MC-Ingress-Time: 1578672034819 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=subject:to :references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=gotplt.org; bh=UL/Cgj nNU/DYJ4ujLWq/JbrbGU0=; b=wqPhqp1njnGL917yunlXBlFLbsZllquQ/njPPV 6UxXXauFKzv9wQNpCKb/JCTaR4HHBoN/3B+EzKNNmH2EQ/Mt6OLtDgjSOZP+OKGH FlzW045/R0lAUNq7Rt7wgzjljET+5NhGQyBhVpn3MbKdyqKjVsnPwu0eugKAVbQh PvzIM= Subject: Re: [PATCH v2] elf: Add tst-ldconfig-ld_so_conf-update test To: Stefan Liebler , libc-alpha@sourceware.org References: <20191205172608.GA57577@aloka.lostca.se> <20191216143424.22882-1-ahajkova@redhat.com> <20200106180509.GA71028@aloka.lostca.se> <56533d16-d7d1-4e79-5a8f-ed4accb17247@gotplt.org> <357df77f-f709-8b35-b28d-e64f4524f92a@linux.ibm.com> X-DH-BACKEND: pdx1-sub0-mail-a10 From: Siddhesh Poyarekar Message-ID: <4e54f470-f07d-558a-b52e-031fb5df1a9d@gotplt.org> Date: Fri, 10 Jan 2020 16:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <357df77f-f709-8b35-b28d-e64f4524f92a@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrvdeifedgkedtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepuffvfhfhkffffgggjggtgfesthejredttdefjeenucfhrhhomhepufhiugguhhgvshhhucfrohihrghrvghkrghruceoshhiugguhhgvshhhsehgohhtphhlthdrohhrgheqnecukfhppedutdefrdduleelrddujeefrdelnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopegludelvddrudeikedrkeeirdehgegnpdhinhgvthepuddtfedrudelledrudejfedrledprhgvthhurhhnqdhprghthhepufhiugguhhgvshhhucfrohihrghrvghkrghruceoshhiugguhhgvshhhsehgohhtphhlthdrohhrgheqpdhmrghilhhfrhhomhepshhiugguhhgvshhhsehgohhtphhlthdrohhrghdpnhhrtghpthhtohepshhtlhhisehlihhnuhigrdhisghmrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-SW-Source: 2020-01/txt/msg00178.txt.bz2 On 10/01/20 8:15 pm, Stefan Liebler wrote: > Hi, > > If run on 32bit, this test fails while renaming tst-ldconfig-ld-mod.so > as there is no /usr/lib64 directory. > > The attached patch is constructing the file name with help of > support_libdir_prefix. > > If the patch is okay, let me know if I can commit it on master. Nice catch, looks OK to me. Reviewed-by: Siddhesh Poyarekar