From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21731 invoked by alias); 13 Sep 2017 12:22:46 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 21719 invoked by uid 89); 13 Sep 2017 12:22:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:1283 X-HELO: mail-qk0-f182.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VFTuPKe60UbPCYu/xdmeBKS7fSD3Lvuk/hPZarTZjjo=; b=IjTnQ80pSf+bUNvPJiXTam1vG82vem6JHMEE9g3G+OChNRPsQpN0hhZYF4sIkzrRYU s9/frkbNYZTpHuUgduXqJsgG5ucs33N/UxImLr0acivJSfApaWnWqJXHmBAxqziFk/aj 1ulVK8jCtFIwtpc9zB44kSM50sTLGJNhwNkDA9LqXx5Ku4Qv1qGwNc7oR1PsZFrRWqmn qWF2KxtJbCW0jukwUjm4srD3c5LWft6prhbdjV7dRcF4cwhRfLJfNA7uLkYxMP+tlqDO BBZ+8IMAlPF72c5vVjKfYkZTo46NEQltM6MO/DeMHrdaylJeibc5A9rW0LUVUl8C1Lvj vBsQ== X-Gm-Message-State: AHPjjUj/z5Sm29R586lzJv9VmoXpn8G/vdCEujJN3kJjT9rlfACOSGiC D4klhHuESVxhHz7Y3M9T5A== X-Google-Smtp-Source: AOwi7QAOsMyzfypDTJybVkockeHyLlFHYGHw0gdpl6HyhYy4vPmIdj2vVXo4exiEkv9fyuYpq8HnHA== X-Received: by 10.55.15.96 with SMTP id z93mr3806865qkg.237.1505305361894; Wed, 13 Sep 2017 05:22:41 -0700 (PDT) Subject: Re: [PATCH 3/9] posix: Allow glob to match dangling symlinks [BZ #866] To: Paul Eggert , Zack Weinberg Cc: Joseph Myers , Andreas Schwab , GNU C Library References: <1504643122-14874-1-git-send-email-adhemerval.zanella@linaro.org> <1504643122-14874-4-git-send-email-adhemerval.zanella@linaro.org> <878thop5fa.fsf@linux-m68k.org> <9455e298-8c48-c42a-0ec3-ffb8d166c69b@linaro.org> <450d2eab-f21a-f90c-6210-ea638787e339@cs.ucla.edu> <403decc7-e039-9be1-fb44-25d611540156@linaro.org> <7bf58b8a-afc9-b934-9a4a-1616e71c03ff@cs.ucla.edu> <805e4d8a-de63-5253-e214-b3912ed221e3@cs.ucla.edu> <30b5f782-8fb0-5b38-3b4c-6ebf435bc91c@linaro.org> <95745cd2-0033-8a3c-92af-879c24d0d396@cs.ucla.edu> From: Adhemerval Zanella Message-ID: <4e71b51c-3ec8-bb11-19bd-8fc27d4ede3e@linaro.org> Date: Wed, 13 Sep 2017 12:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <95745cd2-0033-8a3c-92af-879c24d0d396@cs.ucla.edu> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2017-09/txt/msg00544.txt.bz2 On 13/09/2017 06:14, Paul Eggert wrote: > Adhemerval Zanella wrote: >> Another approach that does not involve adding compat symbols (which adds >> a lot of code complexity inside glibc build and do not solve 'make' builds >> against new glibc) would to make GLOB_ALTDIRFUNCS to follow the old semantic >> of using gl_stat instead of gl_lstat while making glob without GLOB_ALTDIRFUNCS >> works as intended. And add another flag, GLOB_ALTDIRFUNCS2, which actually >> uses gl_lstat. > > Although that's clever, it is a gratuitous source-code incompatibility with BSD, which is not a good thing. To some extent it's just GLOB_FOLLOW and GLOB_NOFOLLOW in disguise, and disguise is not a good thing in APIs. So I think I still prefer the compat symbol approach. > > We'll get GNU 'Make' fixed, and I wouldn't worry overly much about people building unpatched 'Make' with new glibc. I filed a Make bug report is here: > > http://lists.gnu.org/archive/html/bug-make/2017-09/msg00014.html Right, I am mainly trying to avoid bring more internal glob implementation complexity to glibc, but since you says the unpatched 'Make' built against newer glibc shouldn't be a problem I think we can this way. I will work on it.