From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id CE35B3858C52 for ; Fri, 3 Feb 2023 21:13:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CE35B3858C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 313L6ci0028057; Fri, 3 Feb 2023 21:13:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=rndlLv/fjH211TQbdgcTvYcANk8jz/skhoRR8SLiP8k=; b=HJzBm6RXICPOOAJ5cjD7VfDnRkZPMRpaig1IYtuLNyBv987JrQwZjZ9fUzy4g14ri9nH Z7DgHLa2pflQje2JpbUerODX6FPvYy2UNF1FCdxBtkyI9LRrns5hz5FojwtEhbnMyLmK ibZDxVPhB4ic6eQ1pmtaLmXonYiJLYMZ4qvAYgNSR1LZQTHYbER3vhJTHkmayHZzeFZR JF1z8fpITb7La6d5cBWHmCbdPbhMmuO28sDX3xaX2nGzuCK8i6+a8l63YCkcxgh4psio tbdDlPVMWyoOpRGVHUjrSsckXJk3AUgtmIBg7o9HljDzifF1Fp2JjFlL0fniP+fRRgoc Yw== Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3nh7by3x4b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 03 Feb 2023 21:13:54 +0000 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 313KIhf6006508; Fri, 3 Feb 2023 21:13:54 GMT Received: from smtprelay03.wdc07v.mail.ibm.com ([9.208.129.113]) by ppma01dal.us.ibm.com (PPS) with ESMTPS id 3ncvtn3baj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 03 Feb 2023 21:13:54 +0000 Received: from smtpav02.wdc07v.mail.ibm.com (smtpav02.wdc07v.mail.ibm.com [10.39.53.229]) by smtprelay03.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 313LDqLq59834710 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 3 Feb 2023 21:13:52 GMT Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A19CD5805B; Fri, 3 Feb 2023 21:13:52 +0000 (GMT) Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 24F9D58059; Fri, 3 Feb 2023 21:13:52 +0000 (GMT) Received: from [9.65.213.153] (unknown [9.65.213.153]) by smtpav02.wdc07v.mail.ibm.com (Postfix) with ESMTP; Fri, 3 Feb 2023 21:13:51 +0000 (GMT) Message-ID: <4e9b536a-3b26-d30c-ee4c-d75f4d613e29@linux.ibm.com> Date: Fri, 3 Feb 2023 15:13:51 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 1/5] powerpc64: Add the clone3 wrapper Content-Language: en-US To: Adhemerval Zanella , libc-alpha@sourceware.org References: <20230203171237.1220878-1-adhemerval.zanella@linaro.org> <20230203171237.1220878-2-adhemerval.zanella@linaro.org> From: Paul E Murphy In-Reply-To: <20230203171237.1220878-2-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: dpY2P3AuLxUUZYKCe1yKfdC5xu-6rnOG X-Proofpoint-ORIG-GUID: dpY2P3AuLxUUZYKCe1yKfdC5xu-6rnOG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-02-03_19,2023-02-03_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0 suspectscore=0 phishscore=0 malwarescore=0 clxscore=1011 spamscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 mlxlogscore=929 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302030189 X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/3/23 11:12 AM, Adhemerval Zanella via Libc-alpha wrote: > It follows the internal signature: > > extern int clone3 (struct clone_args *__cl_args, size_t __size, > int (*__func) (void *__arg), void *__arg); > > The powerpc64 ABI requires an initial stackframe so the child can > store/restore the TOC. It is create prior calling clone3 by > adjusting the stack size (since kernel will compute the stack as > stack plus size). > > Checked on powerpc64-linux-gnu (power8, kernel 6.0) and > powerpc64le-linux-gnu (power9, kernel 4.18). Thanks. LGTM. Reviewed-by: Paul E. Murphy