From: Mark Wielaard <mark@klomp.org>
To: Florian Weimer <fw@deneb.enyo.de>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 1/4] time/tst-clock2.c: clock_settime CLOCK_MONOTONIC might return EPERM
Date: Mon, 27 Jun 2022 11:35:07 +0200 [thread overview]
Message-ID: <4ebf3eacedf6133d048192ee5fe1cfe2f91393b1.camel@klomp.org> (raw)
In-Reply-To: <87pmivnn28.fsf@mid.deneb.enyo.de>
Hi Florian,
On Sun, 2022-06-26 at 23:15 +0200, Florian Weimer wrote:
> * Mark Wielaard:
> > - printf ("clock_settime(CLOCK_MONOTONIC) set errno to %d,
> > expected %d\n",
> > - errno, EINVAL);
> > + printf ("clock_settime(CLOCK_MONOTONIC) set errno to %d,
> > expected %d or %d\n",
> > + errno, EINVAL, EPERM);
> > return 1;
> > }
> > return 0;
>
> You could use "errno to %d (%#m)" if you are changing this line
> anyway.
> And isn't the line too long?
>
> Direction looks okay to me.
Yes, the line is too long. Sorry, my terminal window was too wide. Will
fix and add (%#m) in v2.
Thanks,
Mark
next prev parent reply other threads:[~2022-06-27 9:35 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-26 20:59 Handle running make check in a restricted environment Mark Wielaard
2022-06-26 20:59 ` [PATCH 1/4] time/tst-clock2.c: clock_settime CLOCK_MONOTONIC might return EPERM Mark Wielaard
2022-06-26 21:15 ` Florian Weimer
2022-06-27 9:35 ` Mark Wielaard [this message]
2022-06-26 20:59 ` [PATCH 2/4] tst-pkey.c: Handle no permission to alloc memory protection keys Mark Wielaard
2022-06-26 21:17 ` Florian Weimer
2022-06-26 21:40 ` Florian Weimer
2022-06-27 9:50 ` Mark Wielaard
2022-06-27 11:39 ` Florian Weimer
2022-06-27 14:08 ` Mark Wielaard
2022-06-26 20:59 ` [PATCH 3/4] tst-pidfd.c: Test is UNSUPPORTED without PTRACE_MODE_ATTACH_REALCREDS Mark Wielaard
2022-06-26 21:20 ` Florian Weimer
2022-06-27 10:01 ` Mark Wielaard
2022-06-27 11:14 ` Florian Weimer
2022-06-27 11:51 ` Christian Brauner
2022-06-27 14:17 ` Mark Wielaard
2022-06-27 14:21 ` Adhemerval Zanella
2022-06-27 14:25 ` Christian Brauner
2022-06-27 14:42 ` Florian Weimer
2022-06-27 14:57 ` Adhemerval Zanella
2022-06-27 15:08 ` Christian Brauner
2022-06-27 15:14 ` Adhemerval Zanella
2022-06-27 16:48 ` Mark Wielaard
2022-06-27 17:03 ` Adhemerval Zanella
2022-07-01 10:38 ` Mark Wielaard
2022-06-27 15:03 ` Christian Brauner
2022-06-27 14:23 ` Adhemerval Zanella
2022-06-27 16:36 ` Mark Wielaard
2022-06-26 20:59 ` [PATCH 4/4] tst-personality.c: Handle personality failing with errno EPERM Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ebf3eacedf6133d048192ee5fe1cfe2f91393b1.camel@klomp.org \
--to=mark@klomp.org \
--cc=fw@deneb.enyo.de \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).