From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mark@klomp.org>
Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184])
 by sourceware.org (Postfix) with ESMTPS id 031863841447
 for <libc-alpha@sourceware.org>; Mon, 27 Jun 2022 09:35:14 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 031863841447
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=klomp.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org
Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl
 [83.87.18.245])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by gnu.wildebeest.org (Postfix) with ESMTPSA id 5AB9D30005B6;
 Mon, 27 Jun 2022 11:35:08 +0200 (CEST)
Received: by tarox.wildebeest.org (Postfix, from userid 1000)
 id 9843A4000C41; Mon, 27 Jun 2022 11:35:07 +0200 (CEST)
Message-ID: <4ebf3eacedf6133d048192ee5fe1cfe2f91393b1.camel@klomp.org>
Subject: Re: [PATCH 1/4] time/tst-clock2.c: clock_settime CLOCK_MONOTONIC
 might return EPERM
From: Mark Wielaard <mark@klomp.org>
To: Florian Weimer <fw@deneb.enyo.de>
Cc: libc-alpha@sourceware.org
Date: Mon, 27 Jun 2022 11:35:07 +0200
In-Reply-To: <87pmivnn28.fsf@mid.deneb.enyo.de>
References: <20220626205915.33201-1-mark@klomp.org>
 <20220626205915.33201-2-mark@klomp.org> <87pmivnn28.fsf@mid.deneb.enyo.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) 
Mime-Version: 1.0
X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Jun 2022 09:35:16 -0000

Hi Florian,

On Sun, 2022-06-26 at 23:15 +0200, Florian Weimer wrote:
> * Mark Wielaard:
> > -      printf ("clock_settime(CLOCK_MONOTONIC) set errno to %d,
> > expected %d\n",
> > -	      errno, EINVAL);
> > +      printf ("clock_settime(CLOCK_MONOTONIC) set errno to %d,
> > expected %d or %d\n",
> > +	      errno, EINVAL, EPERM);
> >        return 1;
> >      }
> >    return 0;
>=20
> You could use "errno to %d (%#m)" if you are changing this line
> anyway.
> And isn't the line too long?
>=20
> Direction looks okay to me.

Yes, the line is too long. Sorry, my terminal window was too wide. Will
fix and add (%#m) in v2.

Thanks,

Mark