From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id C69B83857811 for ; Mon, 30 Nov 2020 17:00:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C69B83857811 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0AUGWAQ3105213 for ; Mon, 30 Nov 2020 12:00:55 -0500 Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0b-001b2d01.pphosted.com with ESMTP id 3552qw4qcf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 30 Nov 2020 12:00:55 -0500 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0AUGpLje008603 for ; Mon, 30 Nov 2020 17:00:54 GMT Received: from b03cxnp08028.gho.boulder.ibm.com (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20]) by ppma03wdc.us.ibm.com with ESMTP id 353e68s77g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 30 Nov 2020 17:00:54 +0000 Received: from b03ledav006.gho.boulder.ibm.com (b03ledav006.gho.boulder.ibm.com [9.17.130.237]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0AUH0rIw56754608 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 30 Nov 2020 17:00:53 GMT Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8484BC60A2; Mon, 30 Nov 2020 17:00:53 +0000 (GMT) Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F1F19C60A4; Mon, 30 Nov 2020 17:00:52 +0000 (GMT) Received: from [9.163.22.199] (unknown [9.163.22.199]) by b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP; Mon, 30 Nov 2020 17:00:52 +0000 (GMT) Subject: Re: [PATCHv5] powerpc64le: ifunc select *f128 routines in multiarch mode To: "Paul E. Murphy" , libc-alpha@sourceware.org References: <20201102152742.97585-1-murphyp@linux.ibm.com> From: Raphael M Zinsly Message-ID: <4ed32327-5395-dff2-1add-6b3b5b0fc721@linux.ibm.com> Date: Mon, 30 Nov 2020 14:00:51 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20201102152742.97585-1-murphyp@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312, 18.0.737 definitions=2020-11-30_05:2020-11-30, 2020-11-30 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 mlxlogscore=999 priorityscore=1501 spamscore=0 phishscore=0 clxscore=1011 impostorscore=0 suspectscore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011300102 X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Nov 2020 17:00:57 -0000 On 02/11/2020 12:27, Paul E. Murphy via Libc-alpha wrote: > Programatically generate simple wrappers for interesting libm *f128 > objects. Selected functions are transcendental functions or > those with trivial compiler builtins. This can result in a 2-3x > speedup (e.g logf128 and expf128). > > A second set of implementation files are generated which include > the first implementation encountered along the search path. This > usually works, except when a wrapper is overriden and makefile > search order slightly diverges from include order. Likewise, > wrapper object files are created for each generated file. These > hold the ifunc selection routines which export ABI. > > Next, several shared headers are intercepted to control renaming of > asm function redirects are used first, and sometimes macro renames > if the former is impractical. > > Notably, if the request machine supports hardware IEEE128 (i.e POWER9 > and newer) this ifunc machinery is disabled. Likewise existing > ifunc support for float128 is consolidated into this (e.g sqrtf128 > and fmaf128). LGTM, I tested on POWER8 and POWER9. -- Raphael Moreira Zinsly IBM Linux on Power Toolchain