From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v3 03/21] nptl: x86_64: Fix Race conditions in pthread cancellation (BZ#12683)
Date: Wed, 16 Oct 2019 21:22:00 -0000 [thread overview]
Message-ID: <4f171c10-1439-03cd-5966-a5eb8ee78333@linaro.org> (raw)
In-Reply-To: <877e56fexz.fsf@oldenburg2.str.redhat.com>
On 15/10/2019 08:03, Florian Weimer wrote:
> * Adhemerval Zanella:
>
>> diff --git a/sysdeps/unix/sysv/linux/x86_64/syscall_cancel.S b/sysdeps/unix/sysv/linux/x86_64/syscall_cancel.S
>> new file mode 100644
>> index 0000000000..c7364bfff8
>> --- /dev/null
>> +++ b/sysdeps/unix/sysv/linux/x86_64/syscall_cancel.S
>
>> +ENTRY (__syscall_cancel_arch)
>> +
>> + .globl __syscall_cancel_arch_start
>> + .type __syscall_cancel_arch_start,@function
>
> I don't think we should specify a type for this symbol. It's not a
> function.
Ack, I can't recall exactly I have added it on previous iterations.
I removed it.
>
>> +__syscall_cancel_arch_start:
>> +
>> + /* if (*cancelhandling & CANCELED_BITMASK)
>> + __syscall_do_cancel() */
>> + mov (%rdi),%eax
>> + testb $4, (%rdi)
>> + jne __syscall_do_cancel
>
> I'm pretty sure 4 should be one of the _BITMASK constants.
Right, I think we should use TCB_CANCELED_BITMASK macro for this (and
add it for architectures that do not define it already).
>
>> + /* Issue a 6 argument syscall, the nr [%rax] being the syscall
>> + number. */
>> + mov %rdi,%r11
>> + mov %rsi,%rax
>> + mov %rdx,%rdi
>> + mov %rcx,%rsi
>> + mov %r8,%rdx
>> + mov %r9,%r10
>> + mov 8(%rsp),%r8
>> + mov 16(%rsp),%r9
>> + mov %r11,8(%rsp)
>> + syscall
>> +
>> + .globl __syscall_cancel_arch_end
>> + .type __syscall_cancel_arch_end,@function
>
> Again, no type here please. It will confuse the disassembler.
Ack.
>
> Thanks,
> Florian
>
next prev parent reply other threads:[~2019-10-16 21:22 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 20:57 [PATCH v3 00/21] nptl: " Adhemerval Zanella
2019-10-14 20:57 ` [PATCH v3 08/21] nptl: aarch64: " Adhemerval Zanella
2019-10-14 20:57 ` [PATCH v3 05/21] nptl: ia64: " Adhemerval Zanella
2019-10-14 20:57 ` [PATCH v3 20/21] nptl: csky: " Adhemerval Zanella
2019-10-14 20:57 ` [PATCH v3 16/21] nptl: sh: " Adhemerval Zanella
2019-10-14 20:57 ` [PATCH v3 02/21] nptl: " Adhemerval Zanella
2019-10-15 10:56 ` Florian Weimer
2019-10-16 20:42 ` Adhemerval Zanella
2019-10-18 12:38 ` Internal SIGTIMER use (was: Re: [PATCH v3 02/21] nptl: Fix Race conditions in pthread cancellation (BZ#12683)) Florian Weimer
2019-10-21 13:29 ` Adhemerval Zanella
2019-10-14 20:57 ` [PATCH v3 07/21] nptl: i386: Fix Race conditions in pthread cancellation (BZ#12683) Adhemerval Zanella
2019-10-14 20:57 ` [PATCH v3 03/21] nptl: x86_64: " Adhemerval Zanella
2019-10-15 11:03 ` Florian Weimer
2019-10-16 21:22 ` Adhemerval Zanella [this message]
2019-10-14 20:57 ` [PATCH v3 12/21] nptl: sparc: " Adhemerval Zanella
2019-10-14 20:57 ` [PATCH v3 09/21] nptl: arm: " Adhemerval Zanella
2019-10-14 20:57 ` [PATCH v3 13/21] nptl: hppa: " Adhemerval Zanella
2019-10-14 20:57 ` [PATCH v3 19/21] nptl: nios2: " Adhemerval Zanella
2019-10-14 20:57 ` [PATCH v3 04/21] nptl: x32: " Adhemerval Zanella
2019-10-15 11:06 ` Florian Weimer
2019-10-14 20:57 ` [PATCH v3 15/21] nptl: alpha: " Adhemerval Zanella
2019-10-17 3:01 ` Matt Turner
2019-10-14 20:57 ` [PATCH v3 10/21] nptl: powerpc: " Adhemerval Zanella
2019-10-14 20:57 ` [PATCH v3 17/21] nptl: riscv: " Adhemerval Zanella
2019-10-14 23:22 ` Andrew Waterman
2019-10-14 20:57 ` [PATCH v3 18/21] nptl: s390: " Adhemerval Zanella
2019-10-16 15:46 ` Stefan Liebler
2019-10-17 13:54 ` Adhemerval Zanella
2019-10-17 15:01 ` Stefan Liebler
2019-10-17 19:46 ` Adhemerval Zanella
2019-10-18 12:58 ` Stefan Liebler
2019-10-14 20:57 ` [PATCH v3 14/21] nptl: m68k: " Adhemerval Zanella
2019-10-14 21:13 ` Andreas Schwab
2019-10-14 20:57 ` [PATCH v3 06/21] nptl: mips: " Adhemerval Zanella
2019-10-14 20:57 ` [PATCH v3 01/21] nptl: Handle EPIPE on tst-cancel2 Adhemerval Zanella
2019-10-15 9:03 ` Florian Weimer
2019-10-14 20:57 ` [PATCH v3 11/21] nptl: microblaze: Fix Race conditions in pthread cancellation (BZ#12683) Adhemerval Zanella
2019-10-14 20:58 ` [PATCH v3 21/21] Remove sysdep-cancel header Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f171c10-1439-03cd-5966-a5eb8ee78333@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).