From: Siddhesh Poyarekar <siddhesh@sourceware.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Siddhesh Poyarekar via Libc-alpha <libc-alpha@sourceware.org>,
fweimer@redhat.com, Qualys Security Advisory <qsa@qualys.com>
Subject: Re: [PATCH 3/3] getcwd: Set errno to ERANGE for size == 1 (CVE-2021-3999)
Date: Tue, 18 Jan 2022 18:46:36 +0530 [thread overview]
Message-ID: <4f6c58a4-7176-538f-63c5-827ee1f8f9a7@sourceware.org> (raw)
In-Reply-To: <871r1589v5.fsf@igel.home>
On 18/01/2022 18:43, Andreas Schwab wrote:
> On Jan 18 2022, Siddhesh Poyarekar wrote:
>
>> We then process it to try and get the cwd anyway by using the posix
>> variant.
>
> Which returns the appropriate error.
>
In the specific case of an unprivileged mount on the same directory, it
ends up underflowing the buffer before returning. Whether it returns
the right error or not becomes irrelevant then. Please see the reproducer.
Siddhesh
next prev parent reply other threads:[~2022-01-18 13:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 9:07 [PATCH 0/3] Fixes for CVE-2021-3998 and CVE-2021-3999 Siddhesh Poyarekar
2022-01-18 9:07 ` [PATCH 1/3] support: Add helpers to create paths longer than PATH_MAX Siddhesh Poyarekar
2022-01-18 19:42 ` Adhemerval Zanella
2022-01-19 1:33 ` Siddhesh Poyarekar
2022-01-18 9:07 ` [PATCH 2/3] realpath: Set errno to ENAMETOOLONG for result larger than PATH_MAX [BZ #28770] Siddhesh Poyarekar
2022-01-18 19:43 ` Adhemerval Zanella
2022-01-18 9:07 ` [PATCH 3/3] getcwd: Set errno to ERANGE for size == 1 (CVE-2021-3999) Siddhesh Poyarekar
2022-01-18 11:52 ` Andreas Schwab
2022-01-18 13:10 ` Siddhesh Poyarekar
2022-01-18 13:13 ` Andreas Schwab
2022-01-18 13:16 ` Siddhesh Poyarekar [this message]
2022-01-18 13:30 ` Andreas Schwab
2022-01-18 13:33 ` Siddhesh Poyarekar
2022-01-18 13:41 ` Andreas Schwab
2022-01-18 13:45 ` Siddhesh Poyarekar
2022-01-18 13:56 ` Siddhesh Poyarekar
2022-01-18 13:57 ` Andreas Schwab
2022-01-18 14:40 ` Siddhesh Poyarekar
2022-01-18 13:59 ` Adhemerval Zanella
2022-01-18 14:44 ` Siddhesh Poyarekar
2022-01-18 16:30 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f6c58a4-7176-538f-63c5-827ee1f8f9a7@sourceware.org \
--to=siddhesh@sourceware.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=qsa@qualys.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).