From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by sourceware.org (Postfix) with ESMTPS id 3B31C3858025 for ; Tue, 11 May 2021 05:21:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3B31C3858025 Received: by mail-pj1-x102a.google.com with SMTP id ge1so11043955pjb.2 for ; Mon, 10 May 2021 22:21:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:cc:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ua2iUNGT7xhnqaAjEUTTZX8O/U/lplbApUl/UHhNtYM=; b=X48LzCdFmVsi1RDE6CjWs3T9XxB3Bq7GrDFuDun5Zs2ckle3KAd+uVwwfvMZF2xjXa QwbVxmULH84UaLiZA8QPHCc76fWsQgVz3yvvwwCXeCyEbFq5W21p+pU2uIvYaudY4DBy nqAH6RRVUEQemz9Mo59X04k1TGDh4T52jXQ8KbF7sfSKxJFJ56JKUwCwOdIvalfJmOSS uSv6fO63DTuTecvAzoNM1aPYItQZliosOBpvj602bzLqje7DjMNKtpkwO2jNVGjtBUEd bZaNpxcN0T7qx2J3Y+rLx4XfgwBt90dOYCWjo6FNY6lSDSkSagEvRtKhzONQZ2Vgzqsf 1+Sg== X-Gm-Message-State: AOAM533AYqJfRD2mBmws9yArENUKPAhUrLxZG8lVzCni0tjwbV6HZHQc P65I+r9k65Vh5IUO4m6rZA3340QkLwU= X-Google-Smtp-Source: ABdhPJy3ckBTRO6JCyt2aH9Frkd+PQuLU6a1kESYvlfX4ttkfCda6jFwnG0bEqcGEThyXGu10yrL/g== X-Received: by 2002:a17:902:c211:b029:ed:7a6b:d4bf with SMTP id 17-20020a170902c211b02900ed7a6bd4bfmr28260509pll.63.1620710510216; Mon, 10 May 2021 22:21:50 -0700 (PDT) Received: from [192.168.192.21] (47-72-82-130.dsl.dyn.ihug.co.nz. [47.72.82.130]) by smtp.gmail.com with ESMTPSA id x19sm9713120pgk.88.2021.05.10.22.21.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 May 2021 22:21:49 -0700 (PDT) Cc: mtk.manpages@gmail.com, Florian Weimer , Jakub Wilk , linux-man@vger.kernel.org, libc-alpha@sourceware.org Subject: Re: [PATCH 02/39] getdents.2: Use syscall(SYS_...); for system calls without a wrapper To: Alejandro Colomar References: <20210510175546.28445-1-alx.manpages@gmail.com> <20210510175546.28445-3-alx.manpages@gmail.com> From: "Michael Kerrisk (man-pages)" Message-ID: <4f86a450-2348-c059-4f26-f81593a8b707@gmail.com> Date: Tue, 11 May 2021 17:21:45 +1200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210510175546.28445-3-alx.manpages@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 May 2021 05:21:52 -0000 Hi Alex, See below. On 5/11/21 5:55 AM, Alejandro Colomar wrote: > Signed-off-by: Alejandro Colomar > --- > man2/getdents.2 | 20 +++++++++++++++----- > 1 file changed, 15 insertions(+), 5 deletions(-) > > diff --git a/man2/getdents.2 b/man2/getdents.2 > index ec00a73ba..df766b066 100644 > --- a/man2/getdents.2 > +++ b/man2/getdents.2 > @@ -33,19 +33,29 @@ > getdents, getdents64 \- get directory entries > .SH SYNOPSIS > .nf > -.BI "long getdents(unsigned int " fd ", struct linux_dirent *" dirp , > +.BR "#include " " /* Definition of " SYS_* " constants */" > +.B #include > +.PP > +.BI "long syscall(SYS_getdents, unsigned int " fd \ > +", struct linux_dirent *" dirp , > .BI " unsigned int " count ); > .PP > -.BR "#define _GNU_SOURCE" " /* See feature_test_macros(7) */" > +.BR "#define _GNU_SOURCE" " /* See feature_test_macros(7) */" > .BR "#include " > .PP > .BI "ssize_t getdents64(int " fd ", void *" dirp ", size_t " count ); > .fi > .PP > .IR Note : > -There is no glibc wrapper for > -.BR getdents (); > -see NOTES. > +glibc provides no wrapper for > +.BR getdents (), > +necessitating the use of > +.BR syscall (2). > +.PP > +.IR Note : > +There is no definition of > +.B struct linux_dirent .I ... (Fixed) > +in glibc; see NOTES. > .SH DESCRIPTION > These are not the interfaces you are interested in. > Look at > Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/