From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 361FD388B015 for ; Mon, 4 May 2020 15:43:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 361FD388B015 Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-8-CZQSknd1MO-O0X_iZIm5qQ-1; Mon, 04 May 2020 11:43:24 -0400 X-MC-Unique: CZQSknd1MO-O0X_iZIm5qQ-1 Received: by mail-qk1-f199.google.com with SMTP id g143so1211851qke.12 for ; Mon, 04 May 2020 08:43:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=9r1pSQs1w8UFRhKeDY2glphqsCCFxHUqcH2yH/iQ+J0=; b=d1cFKPg/65DdUP54gfGt4ASvHGO9Ca6HMZLe8aAjsHf/KF3lH7TAUsh2QbNRQ7wIZD j4hDbHyj4m3a7QeqzGTxfcxY25gsShDggwOxmpRahhyXl8lik+EUPpYtzCTO+ZQ9C6Kg cOExkhXPKsDzf1pdcGyHjfXw5ZIagqWqvUD/pZyJxiCiRX+ohV6L7VPYKXL7QQWL32jz eFunZOvQD7Qku3DpHbodsIuEbi3f8n65CVBjnPlriZJTKz+GoopyIMRiG8n2mAu9BO0F WHvHBEo5nlrrTm1u5oDub0ae0TWwJLilqE9Ey4ehAF9D5AGdga2zQZQjW+28ofCgez5A Y7uw== X-Gm-Message-State: AGi0PuZuqbvLAv/qn+v/494g6+szHRJQh0pLuTqQhZBkxlgfSojWoMuS V15bAfE07UgOJlwJ3hLYRaZ8aOX/8QkeKnJLvg0mti4o/YYFiZn3x0eS+6Y+JZ68DV53F/lgyNl fXs7QQNXt16BAI/jOqcdM X-Received: by 2002:aed:370a:: with SMTP id i10mr18184162qtb.64.1588607002649; Mon, 04 May 2020 08:43:22 -0700 (PDT) X-Google-Smtp-Source: APiQypJkE/MCCyzmYNv3TCjIyOx8ubVL1U6NhZGZntA0eaoIK++TipMO5ld3S8KpBHpsRdwN95o4sA== X-Received: by 2002:aed:370a:: with SMTP id i10mr18184134qtb.64.1588607002332; Mon, 04 May 2020 08:43:22 -0700 (PDT) Received: from [192.168.1.4] (198-84-170-103.cpe.teksavvy.com. [198.84.170.103]) by smtp.gmail.com with ESMTPSA id b10sm10883495qtj.30.2020.05.04.08.43.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 May 2020 08:43:21 -0700 (PDT) Subject: Re: [PATCH] locale/tst-localedef-path-norm: Don't create $(complocaledir) To: "H.J. Lu" Cc: DJ Delorie , GNU C Library References: <726e0641-a5b2-9910-90c4-9e3800e0ec0f@redhat.com> From: Carlos O'Donell Organization: Red Hat Message-ID: <4fb0c47d-195c-5077-b241-803660c21caa@redhat.com> Date: Mon, 4 May 2020 11:43:20 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 May 2020 15:43:34 -0000 On 5/2/20 2:15 PM, H.J. Lu wrote: > On Thu, Apr 30, 2020 at 2:18 PM Carlos O'Donell via Libc-alpha > wrote: >> >> On 4/30/20 3:31 PM, DJ Delorie wrote: >>> "Carlos O'Donell" writes: >>>> Given that we creat $(complocaledir) now we can cleanup an existing test >>>> and remove the xmkdirp for support_complocaledir_prefix. >>>> >>>> OK for master? >>> >>> LGTM >>> >>> Reviewed-by: DJ Delorie >> >> Pushed as #4 in sequence. >> > > Does this cause > > https://sourceware.org/bugzilla/show_bug.cgi?id=25908 The testroot.root is created from testroot.pristine via a two step process: * all containerized tests depend on Makefile:$(objpfx)testroot.pristine/install.stamp - We are forced to create testroot.pristine/ first and that creates the $(complocaledir) directory also. * all containerized tests rsync testroot.pristine into testroot.root to run from. - This is done internally by support/test-container.c. Makefile: 583 $(tests-container) $(addsuffix /tests,$(subdirs)) : \ 584 $(objpfx)testroot.pristine/install.stamp 585 $(objpfx)testroot.pristine/install.stamp : 586 test -d $(objpfx)testroot.pristine || \ 587 mkdir $(objpfx)testroot.pristine 588 # We need a working /bin/sh for some of the tests. 589 test -d $(objpfx)testroot.pristine/bin || \ 590 mkdir $(objpfx)testroot.pristine/bin 591 # We need the compiled locale dir for localedef tests. 592 test -d $(objpfx)testroot.pristine/$(complocaledir) || \ 593 mkdir -p $(objpfx)testroot.pristine/$(complocaledir) By the time we run any container test we would have created the directory, and so the test should see the created directory. The new requirement for the $(complocaledir) invalides old testroot.pristine, so you cannot incrementally build through this change. We do not have rootfs dependencies that are fine-grained enough for this. You have to start from a clean build or this will cause this test to fail. Did you start from a clean build? The alternative is that I would have to duplicate or move all install path creation logic from Makefile to support/test-container.c, and stat them unconditionally at each test (which is a waste). We could have some kind of rootfs revision number we bump if we make incompatible layout changes to force incremental build/check to work. That seems like overkill. Can you reproduce this with a clean build/check? -- Cheers, Carlos.