From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id B82533858D1E for ; Tue, 21 May 2024 12:56:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B82533858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B82533858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::435 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716296182; cv=none; b=gTPPib7/k4PL+LnXDOkWp8GpixGOvwQ87RSMl1HLJMPfO9zIZYksigL6RAY8lPF3wNSCJP27S8VL3Tz/b0G6wSCEhHnIEFaA2ccVSZY52s/lIKSaamLPQjSejDw0N49Q3IVCOpaLvVdT1fYwNSGhe7QT7VAm6XffyKt9jZ13jtU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716296182; c=relaxed/simple; bh=wJrhqaRRxFdOI0yKU/h+qBy7y3OKCjhaYx/XvelWpww=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=pIYqpQpo6RpegzlLZqBGoIXzzz4tIAIFn/KsZ0bUIhj/ER7lVMQaJLAhPsjN19SkjPLrKGhgFYhIbfLl1V+PDtvTk6DaKZ5FyFUZiHXKCADwDmXpGPn523Oi9zP2ebVapbsuV+bdjmFlfmPHa/bVIBxKM8HCvZ7OAoeICgb1TVQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-6f47787a0c3so347003b3a.0 for ; Tue, 21 May 2024 05:56:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716296180; x=1716900980; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=5KJ2xKc6BUUYTj/Oln+Ivn3BuLEIilIJN59iZx7SF34=; b=QqBfoUHvoy38C2IrjkzVipHlzqR4TWkx4C2siYimOngMdyownn0ZdXMpOasiacx3Ox Ft2qGiVhUpNfolXwlgbeX6pMWBW0ZDyA8T6kE5XWE0E6Z5MFBee2bWJfkpgZmcP/V/X8 uNnjzikp9Aulz+J0za5kr6Dik2ij5l9LPbTeIDf0dXxaCvfYBiWiLpuR7t6mSrLvFOoQ 58GcIolNGfiKVVlan4go4rIRwBwxoEKx2UMeDFTD5GAk5QOtBdjnkw4IHo2gqBc+gPR7 iYwKe7JzxSA2tcfw2yNH2w/Ik1xReXm0jxP7tlQ1uPWLsY3m38CqKWA8Q+m90DNtJhYm NqnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716296180; x=1716900980; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5KJ2xKc6BUUYTj/Oln+Ivn3BuLEIilIJN59iZx7SF34=; b=ULkpgkmhmSr5JKh4Ae12GZ5tOBu62UTo/I7fZxrR0X6Xmuar2vF704NEcxf5/qWI4j N/fUQ154fUyzlnGAInCp0bZoOu+ciRSsA/SkFWyQnaOgwiASMfhc8pMeL9ySx90z/n1R ++wi+BDxKZRYOYleQOIuzyCuCcmhmMyGangVHP922iBkyAGNa8Wt5FJwIVdH0hIE2Lyv OWsVF7feeFZV4YytYlmMjj50AtquyxepblcJEpVZsPWY+Z7kKHQP8u3X3O/9wWLMqcaX egyKgblvFePaj3UMcn/fW8/5Z50Y0BNibqY9FwNRuucG8G48HodxDiQSqxpnDhwaOJ0h vb3A== X-Gm-Message-State: AOJu0YwbjrbXP/714COr1a9XsLyleq5p1eTLSDRm49HhxkDBeeNVtM8J 0pmBEEFQdhh/QmSkxAWd+Iukt0uf/VUSqv0yBMRU2lyBPgFpT2TkoGJhjBZ2+HQ= X-Google-Smtp-Source: AGHT+IE5RWyydww6GzsLRSHc5B1vFysL9r5XV22oAEbHuO7aGtES7B2v3UZ1bB7G76cbTRabwweoNg== X-Received: by 2002:a05:6a00:3ccd:b0:6f3:ebc4:4406 with SMTP id d2e1a72fcca58-6f4e026b878mr43969093b3a.7.1716296179676; Tue, 21 May 2024 05:56:19 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c2:f76a:f586:fbab:daec:c9bf? ([2804:1b3:a7c2:f76a:f586:fbab:daec:c9bf]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f4d2b2de1csm21585408b3a.204.2024.05.21.05.56.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 May 2024 05:56:19 -0700 (PDT) Message-ID: <4ff3e06b-dc3f-430b-a3b5-741813eaf2ed@linaro.org> Date: Tue, 21 May 2024 09:56:16 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/7] math: Fix isnanf128 static build To: "H.J. Lu" Cc: libc-alpha@sourceware.org, Joseph Myers , Florian Weimer References: <20240402140644.2172819-1-adhemerval.zanella@linaro.org> <20240402140644.2172819-5-adhemerval.zanella@linaro.org> Content-Language: en-US From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 21/05/24 09:36, H.J. Lu wrote: > On Tue, May 21, 2024 at 5:32 AM Adhemerval Zanella Netto > wrote: >> >> >> >> On 20/05/24 18:34, H.J. Lu wrote: >>> On Tue, Apr 2, 2024 at 7:06 AM Adhemerval Zanella >>> wrote: >>>> >>>> Some static implementation of float128 routines might call __isnanf128, >>>> which is not provided by the static object. >>>> >>>> Checked on x86_64-linux-gnu. >>>> --- >>>> sysdeps/ieee754/float128/float128_private.h | 2 +- >>>> sysdeps/ieee754/float128/s_isnanf128.c | 4 ++++ >>>> 2 files changed, 5 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/sysdeps/ieee754/float128/float128_private.h b/sysdeps/ieee754/float128/float128_private.h >>>> index 38a8bdd0fe..672bf3cccf 100644 >>>> --- a/sysdeps/ieee754/float128/float128_private.h >>>> +++ b/sysdeps/ieee754/float128/float128_private.h >>>> @@ -352,7 +352,7 @@ >>>> #define frexpl frexpf128 >>>> #define getpayloadl getpayloadf128 >>>> #define isinfl isinff128_do_not_use >>>> -#define isnanl isnanf128_do_not_use >>> >>> Why is this change needed? Will the issue be fixed by >> >> This is not required indeed, I will remove it. > > Please mention: > > https://sourceware.org/bugzilla/show_bug.cgi?id=31774 > > in the commit log. Ack. > >>> >>> https://patchwork.sourceware.org/project/glibc/list/?series=34121 >> >> But unfortunately this patch does not fix the missing isnanf128 symbol on libc.a. > > That is not what I meant. I thought your isnanl change fixed some > issue you found. Right, to make it clear your patch https://patchwork.sourceware.org/project/glibc/list/?series=34121 does not fix the missing isnanf128 required for static build of math tests. This is fixed by this patch.