From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by sourceware.org (Postfix) with ESMTPS id 2E32A381DCE9 for ; Fri, 25 Sep 2020 08:13:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2E32A381DCE9 Received: by mail-ed1-x542.google.com with SMTP id k14so1607048edo.1 for ; Fri, 25 Sep 2020 01:13:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:cc:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=I1EFdegNmyn4gbqFQ91ci+a2f67I3aFX4uK20wlXyiM=; b=bSzwBpww4l4cydpUVxEzi2VTIsiAps8K5DFwP8Jh+XPg2WmNSynKHadYSJ6AOf5o1F enD0TbCqwWMrID97ArKuy6OmezibrC3cdWByHPz/gYdlR6k0r83Pf3W6NKF4EZIFf/xd E2tsQdLRMToxzXG8a0G7zMRPQ0yNuMJ6WA8B5eJa5m2S0aJgB9SQGDlJmzl9yY5nZkPc cyS3FdqKiG3l/EUw2TvN456WwsAHwMI0+qDs7fZ8fOHO/6CHOtkTyiZH94IkyyCtKf+K kTYCnd114u4gGNz/pdf45hI70RHKWkI8MDAarvdnQGcrG97vHkPlwfuU7cqdz88RCiMY p4Tw== X-Gm-Message-State: AOAM5300gn0DLRE4Pl1KJ3PsGFeQNDKbpvli412BQH7n8k65VJ+gT48z bEHacvsUZ8F/kSaGBEshKjJ3q0d/7d8= X-Google-Smtp-Source: ABdhPJzweOkHPdoJYhsQEW/BDLCgITBvHzbse3d3fbNkz6OdA4i5GLJnOr9i2hzVX6+0XOLnJxRj0g== X-Received: by 2002:a50:fe07:: with SMTP id f7mr23947edt.173.1601021609934; Fri, 25 Sep 2020 01:13:29 -0700 (PDT) Received: from ?IPv6:2001:a61:2479:6801:d8fe:4132:9f23:7e8f? ([2001:a61:2479:6801:d8fe:4132:9f23:7e8f]) by smtp.gmail.com with ESMTPSA id v25sm1264604edr.29.2020.09.25.01.13.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Sep 2020 01:13:29 -0700 (PDT) Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org, libc-alpha@sourceware.org Subject: Re: [PATCH 04/10] system_data_types.7: Add float_t To: Alejandro Colomar References: <20200925073140.173394-1-colomar.6.4.3@gmail.com> <20200925073140.173394-5-colomar.6.4.3@gmail.com> From: "Michael Kerrisk (man-pages)" Message-ID: <5090c977-c75f-66a4-848f-e7ed94510d16@gmail.com> Date: Fri, 25 Sep 2020 10:13:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200925073140.173394-5-colomar.6.4.3@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_ASCII_DIVIDERS, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Sep 2020 08:13:33 -0000 Hi Alex, A few comments here that also apply for the double_t patch. Could you revise please? On 9/25/20 9:31 AM, Alejandro Colomar wrote: > Signed-off-by: Alejandro Colomar > --- > man7/system_data_types.7 | 36 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > > diff --git a/man7/system_data_types.7 b/man7/system_data_types.7 > index b04457bbf..238b9593b 100644 > --- a/man7/system_data_types.7 > +++ b/man7/system_data_types.7 > @@ -147,6 +147,42 @@ Conforming to: C99 and later; POSIX.1-2001 and later. > .IP > See also: > .BR fenv (3) > +.\"------------------------------------- float_t ----------------------/ > +.TP > +.I float_t > +.IP > +Include: > +.IR . > +.IP > +The implementation's most efficient floating type at least as wide as > +.IR float . The C standard is rather terse here. Perhaps we could make the reader's life a little easier. How about something like: [[ This a type that is intended to be the implementation's most efficient floating type that is at least as wide as .IR float . ]] > +Its type depends on the value of the macro > +.BR FLT_EVAL_METHOD : > +.RS > +.IP * > +0; > +.I float_t > +is > +.IR float . > +.IP * > +1; > +.I float_t > +is > +.IR double . > +.IP * > +2; > +.I float_t > +is > +.IR "long double" . > +.IP * > +Other implementation-defined values. > +.RE I think we can format this better as a hanging list. Something like this: [[ .TP 0 .I float_t is .IR float . .TP 1 .I float_t is .IR double . .TP 2 .I float_t is .IR "long double" . .IP For other values of .BR FLT_EVAL_METHOD , the type of .I float_t is implementation-defined. ]] > +.IP > +Conforming to: C99 and later; POSIX.1-2001 and later. > +.IP > +See also the > +.I double_t > +type in this page. > .\"------------------------------------- gid_t ------------------------/ > .TP > .I gid_t Thanks, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/