From: Florian Weimer <fweimer@redhat.com>
To: Paul Eggert <eggert@cs.ucla.edu>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>,
libc-alpha@sourceware.org
Subject: Re: [PATCH] posix: Sync gnulib regex implementation
Date: Fri, 29 Jun 2018 15:41:00 -0000 [thread overview]
Message-ID: <50b3b084-4049-0ed8-bdf5-3a75547c0894@redhat.com> (raw)
In-Reply-To: <17feeb08-1478-21ae-e581-6ffecfddab5c@cs.ucla.edu>
On 06/29/2018 05:26 PM, Paul Eggert wrote:
> As I recall the last time I suggested adding it, the only concern raised
> was over the licensing boilerplate at the start of the file. I have
> fixed that in Gnulib, so as far as I know the concerns have been
> addressed. We can make intprops.h's addition independent by separating
> its addition into a separate patch, as I proposed in my most-recent email.
Most of intprops.h is untestable due to lack of relevant implementations
existing out there on which the code could be tested, so I think it's
not maintainable and does not match current glibc quality standards.
Florian
next prev parent reply other threads:[~2018-06-29 15:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 16:44 Adhemerval Zanella
2018-06-28 20:22 ` Paul Eggert
2018-06-29 13:48 ` Adhemerval Zanella
2018-06-29 15:26 ` Paul Eggert
2018-06-29 15:41 ` Florian Weimer [this message]
2018-06-29 16:01 ` Adhemerval Zanella
2018-06-29 23:10 ` Paul Eggert
2018-07-03 19:46 ` Adhemerval Zanella
2018-07-03 20:05 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50b3b084-4049-0ed8-bdf5-3a75547c0894@redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=eggert@cs.ucla.edu \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).