From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80788 invoked by alias); 29 Jun 2018 15:41:59 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 80779 invoked by uid 89); 29 Jun 2018 15:41:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=HTo:D*ucla.edu, Hx-languages-length:680, quality X-HELO: mx1.redhat.com Subject: Re: [PATCH] posix: Sync gnulib regex implementation To: Paul Eggert , Adhemerval Zanella , libc-alpha@sourceware.org References: <1530204275-31537-1-git-send-email-adhemerval.zanella@linaro.org> <135856c7-fee5-a5de-4ccb-12bf0b8fe166@linaro.org> <17feeb08-1478-21ae-e581-6ffecfddab5c@cs.ucla.edu> From: Florian Weimer Message-ID: <50b3b084-4049-0ed8-bdf5-3a75547c0894@redhat.com> Date: Fri, 29 Jun 2018 15:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <17feeb08-1478-21ae-e581-6ffecfddab5c@cs.ucla.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2018-06/txt/msg00992.txt.bz2 On 06/29/2018 05:26 PM, Paul Eggert wrote: > As I recall the last time I suggested adding it, the only concern raised > was over the licensing boilerplate at the start of the file. I have > fixed that in Gnulib, so as far as I know the concerns have been > addressed. We can make intprops.h's addition independent by separating > its addition into a separate patch, as I proposed in my most-recent email. Most of intprops.h is untestable due to lack of relevant implementations existing out there on which the code could be tested, so I think it's not maintainable and does not match current glibc quality standards. Florian