From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from beige.yew.relay.mailchannels.net (beige.yew.relay.mailchannels.net [23.83.220.16]) by sourceware.org (Postfix) with ESMTPS id 1669E387606A for ; Fri, 30 Jun 2023 15:30:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1669E387606A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 36AD914247E; Fri, 30 Jun 2023 15:30:37 +0000 (UTC) Received: from pdx1-sub0-mail-a286.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 9A63D14249A; Fri, 30 Jun 2023 15:30:35 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1688139035; a=rsa-sha256; cv=none; b=lgQMZV/HMn08Wg19ceWbgR1OnwiNWsgHGq731IA8HskObfRzVOZHLp/3uqAyyDv5bW2na8 uSv/ApbqLB3827LPMu74VRnSoQKWGu7R5nNjw6MvTMKu5f4l9ob/QKlKmDk1a6sE9atR1s HdCZ2+ftpfTvSmJoxFCajU6KQ7xVcnA2F/H05zyl3Y4+lgKjjdb1M4v7/XNAlhe3mVhnF8 MrJc1Ppk+mHsbaXh2brq22SMbd9UCH1GaqHUoa/GKDI4CRKOfoO47BygU4BUiXXPSnPLTp n0KhdXmrwO+AST4AV0TP7k5DlzR0G+wp9KpLTdH42+D4g60EG9elq9Ui0HTsEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1688139035; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RxIzpvSVNfixOQDUpalXaTsSuod6Zlj/unDyo2bUClU=; b=3Lvq6tNHmgygssGydrcajYHh2xtP+rva4L+NJU0xwhxhmciY1zLrUYwCj+WYtziYBf6Jyc ZkZVwm6AWN3SvkJaeu41sLdlWXIkT6i8nCymXHc9lASJEPDc4TjqMVzDQL96T8VTb75PNA lQYOV3g4EAenLiczrZMC6LhY6Szh2SzTNt7bCYSy1taXZt+zoB6LgiaEX10ffOjYFFbbu8 0MzEw7Cqx0S0UzE44AUsLLi1yNnFFxR3D2COZfeCZi/4Lg4+xC44tr8lhQPH9aHx5UYqw3 BaiPdVaTl8FA8e/92Sh8/i02uI0IaTPanL6kFHWGRvW8B7oV/OytLaXb/8/ZpA== ARC-Authentication-Results: i=1; rspamd-9fcc56855-jzllm; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Good X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Bubble-Wipe: 70fe2b277affc6f9_1688139037013_2759882162 X-MC-Loop-Signature: 1688139037013:1696722888 X-MC-Ingress-Time: 1688139037013 Received: from pdx1-sub0-mail-a286.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.116.217.230 (trex/6.9.1); Fri, 30 Jun 2023 15:30:37 +0000 Received: from [192.168.0.182] (bras-vprn-toroon4834w-lp130-09-174-91-45-44.dsl.bell.ca [174.91.45.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a286.dreamhost.com (Postfix) with ESMTPSA id 4QszmC1n9pz7v; Fri, 30 Jun 2023 08:30:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gotplt.org; s=dreamhost; t=1688139035; bh=RxIzpvSVNfixOQDUpalXaTsSuod6Zlj/unDyo2bUClU=; h=Date:Subject:To:From:Content-Type:Content-Transfer-Encoding; b=GWfzv2tu/xJHkboKF9L3Bi4JlBhRn7Uknb9rPzi4FPjq2lbhtSaIwcXXQKiBB2rsF Or/fIoF1KVpS6hRp6G17jq5XUFejqSbbdzXoOq9LNSKyzl5+wEretrf2b+KqJUjtZn k8yQwPz1JNZhGokdgUgvEJIW3w5R+PeS8b1NLSS3R4ir9+lzSXZFbm2ZacTKhqHDbK iD802QQXCMsVXNU9J36Iz8yq8UnrMZu9PvrchGLsqfVfjdxX1I2Pjr0ERlOmNeO3cc napHWfvmaSY7FGwrfm/MCW1h0PkAbPvfxfbZCG8a6pBaRt6Og+zgjjAOOCeZSmC5g6 xFbbh5n/OAkFA== Message-ID: <514ef51d-5501-5af9-baf6-4885cbcd9fc7@gotplt.org> Date: Fri, 30 Jun 2023 11:30:34 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 14/16] libio/bits/stdio2-decl.h: Avoid PLT entries with _FORTIFY_SOURCE Content-Language: en-US To: =?UTF-8?B?RnLDqWTDqXJpYyBCw6lyYXQ=?= , libc-alpha@sourceware.org References: <20230628084246.778302-1-fberat@redhat.com> <20230628084246.778302-15-fberat@redhat.com> From: Siddhesh Poyarekar In-Reply-To: <20230628084246.778302-15-fberat@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3037.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-06-28 04:42, Frédéric Bérat wrote: > The change is meant to avoid unwanted PLT entry for the fgets_unlocked > routine when _FORTIFY_SOURCE is set. > --- > libio/bits/stdio2-decl.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libio/bits/stdio2-decl.h b/libio/bits/stdio2-decl.h > index 114b06d24b..d7ef7283d6 100644 > --- a/libio/bits/stdio2-decl.h > +++ b/libio/bits/stdio2-decl.h > @@ -122,7 +122,7 @@ extern size_t __fread_chk (void *__restrict __ptr, size_t __ptrlen, > FILE *__restrict __stream) __wur; > > #ifdef __USE_GNU > -extern char *__REDIRECT (__fgets_unlocked_alias, > +extern char *__REDIRECT_FORTIFY (__fgets_unlocked_alias, > (char *__restrict __s, int __n, > FILE *__restrict __stream), fgets_unlocked) > __wur __attr_access ((__write_only__, 1, 2)); Why not the same for all the others? Sid