From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 76EDE3858D28 for ; Tue, 2 Apr 2024 21:10:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 76EDE3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 76EDE3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712092244; cv=none; b=cn7fqgEJ/1qkrCLX7yAtJ14YvrRmUSeo5HvGiMroCOFXDtCnqCSCJUNk74Jc6U3XLs3MA0ubNoAG4bb9P8CGeDDOi/LfT9ChwYxCP2rPMu1+nhWlJ9uC4qFM+UFbDERuTxke8d0IVPhRXx3QUZbyLAW0dJVsBKEVkNi+/5fGlVk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712092244; c=relaxed/simple; bh=D3CHp2dat1GDkdNgX39Dxe/1aTo+JjfotPuxHcBCLgc=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=mIEU4cyzz/7jUrcJwyn7wjYI70APHx3hvf36b7Pq1vkWCW0xaoq0VZpxPTkXzRdscn6JeqN8qkOH5/vFh0FazjmV2fDoX4/W27kWhj7bULDUbnHANt6oc19enAFzov8UsbSuY8SPvNggaGvmv5BiWu20SQEc5fOeiwaq433K7Yc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712092243; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h8g+SdD+o/4x8zF4UQdSf+c8XiSdDHUEfXApv975UXU=; b=gNZHys8G2GJQkwYRh3bnO+PWY9RvZo2Pt6NrAsqQiBNEnvUL9iaB96MZWmg/Upu45jpAAa Om2/P6zLz5oZ8B9yZXPzVaVGwKCRMyYoBykVUcKLlhrGSID36bdN+bwQOF3zugVYV5q0/F 2OORZ2iQ3oyRvK38WvQd2IeawN1ZBTs= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-352-Zl-JXEqiNN2Z8MEmPD5k1w-1; Tue, 02 Apr 2024 17:10:42 -0400 X-MC-Unique: Zl-JXEqiNN2Z8MEmPD5k1w-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-414042da713so1424355e9.0 for ; Tue, 02 Apr 2024 14:10:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712092240; x=1712697040; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lCM75uXOtAQ9fC6Dy+aFmH1u2UsofJtaEgaEjIJezR0=; b=uzH1z8lFmsoE4vwJiCQR8fB0X8POxS8b+y53dDl5Kl2hstG+/uBqZP1c9Hu2bHoukG JsdP+TPhfuZu0K225IW+7zPwZlbHO3W7bRL/GmeQfuabopsv7mmmJXZcZCGYbrIpoj4L qV/ZgpbBI3IQ3usVjV4m4tAriYmrdUHBitvaYSAQ4QIkiTmWJ2rG5XvaF/pL3edt3JUd UeMRZUdABzdolPBaKCF4BeoHJAZIC7+JkOYMaU2G9GAVefwTpe38nEMJw1XSLaAnaJjI 5jr5AA13COQzcX4yAJxodadsePmujxBOOEeGoePQHVmjD6ZOqrC3NQHFx8gtbtJ6FQ4s vbrw== X-Gm-Message-State: AOJu0YwEAKiZmKdszHxQY3AS5PKgOwVzonmsYjaGkFdrbyw+PeEtBpeB SEIfZr8P7VmXvsf2Jq1+8iVeVooJhUkECDJB4hwNEfNqZFFBsypGYJdEDqvv59kWBJhQBvnYGZe chgORuvNCpLNrKQOTt94gRpwxUzDwj4GbDnNQIz4161hrDzdajGL96c0za3De4CVzAQ== X-Received: by 2002:a5d:66d1:0:b0:343:67c2:aa46 with SMTP id k17-20020a5d66d1000000b0034367c2aa46mr458164wrw.34.1712092239786; Tue, 02 Apr 2024 14:10:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEtulD2v9dYXa0u//I8jSJAiwymG99julLuhTg9lnM8AO+HGYZP5hS/NxiK0hGALO/5unZauQ== X-Received: by 2002:a5d:66d1:0:b0:343:67c2:aa46 with SMTP id k17-20020a5d66d1000000b0034367c2aa46mr458145wrw.34.1712092239253; Tue, 02 Apr 2024 14:10:39 -0700 (PDT) Received: from digraph.polyomino.org.uk (digraph.polyomino.org.uk. [2001:8b0:bf73:93f7::51bb:e332]) by smtp.gmail.com with ESMTPSA id bk20-20020a0560001d9400b0033fc06f2d84sm15238541wrb.109.2024.04.02.14.10.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 14:10:38 -0700 (PDT) Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.95) (envelope-from ) id 1rrlOv-0023GY-Gq; Tue, 02 Apr 2024 21:10:37 +0000 Date: Tue, 2 Apr 2024 21:10:37 +0000 (UTC) From: Joseph Myers To: caiyinyu cc: libc-alpha@sourceware.org, adhemerval.zanella@linaro.org, xry111@xry111.site, xuchenghua@loongson.cn Subject: Re: [PATCH] LoongArch: Add soft floating-point fe* function implementations. In-Reply-To: Message-ID: <5169739c-9483-41f0-d8e8-36b4fe8062aa@redhat.com> References: <20240326124623.1245676-1-caiyinyu@loongson.cn> <2193d4f3-6f55-1812-5923-2845226b3011@loongson.cn> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="-1152306461-1857928385-1712092237=:485882" X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1152306461-1857928385-1712092237=:485882 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Sun, 31 Mar 2024, caiyinyu wrote: > LoongArch soft float support was added in version 2.37, but the fe* functions > were not completely added. I want to backport this patch if possible > (it requires some modifications) to the 2.37/38/39/master branch, so the > version of > the relevant symbols in  Versions is GLIBC_2.37. I don't think such new symbol additions are appropriate for backporting; the GLIBC_2.37 symbol version contents should have been fixed at the time 2.37 was released. > diff --git a/sysdeps/loongarch/nofpu/Versions > b/sysdeps/loongarch/nofpu/Versions > index 6d7f6aae6c..73b6a71bbd 100644 > --- a/sysdeps/loongarch/nofpu/Versions > +++ b/sysdeps/loongarch/nofpu/Versions > @@ -1,5 +1,13 @@ >  libc { > +  GLIBC_2.37 { > +    __adddf3; __addsf3; __divdf3; __divsf3; __eqdf2; __eqsf2; > +    __extendsfdf2; __fixdfsi; __fixsfsi; > +    __fixunsdfsi; __fixunssfsi; > +    __floatsidf; __floatsisf; > +    __gedf2; __gesf2; __ledf2; __lesf2; __muldf3; __mulsf3; > +    __negdf2; __negsf2; __subdf3; __subsf3; __truncdfsf2; > +  } I'd tend to expect you also to have the symbols that powerpc-nofpu has at GLIBC_2.4 version. __floatundidf; __floatundisf; __floatunsidf; __floatunsisf; __unorddf2; __unordsf2; __nedf2; __nesf2; __gtdf2; __gtsf2; __ltdf2; __ltsf2; Also, as LoongArch uses binary128 long double, I'd expect all the TFmode symbols as well. And as a 64-bit architecture, I'd expect TImode symbols (conversions between floating modes and 128-bit signed and unsigned integers, in both directions) as well. -- Joseph S. Myers josmyers@redhat.com ---1152306461-1857928385-1712092237=:485882--