From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 18274385841F for ; Sat, 13 Apr 2024 23:07:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 18274385841F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 18274385841F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713049642; cv=none; b=M3KHFqVZFC8L4XUVlDXu3Nk3CCQg6UQRHB2VDmPYJVtg3NEjPDdHoWd2605M2MtyFjQRoo2YhDSbHOc1H9tYmDBsn/S+e80QRcNzeRfK4prXz7wPjjh9avshedf77LiYJ3C2DXTntGK7UMUcCOHhW6+i8FlE7PLjeojRGct83as= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713049642; c=relaxed/simple; bh=13ZMfDnVArgLJKhl9atniPY3iHsk3gkJvxIPWRuruso=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=tOzGa5yd0YbBBfu7HtBiaOMrNNe4KHrM/qCr3y4pLe7OrxXBAtQlKzpcwMKq88kDrNZo9uOlYSLrJZzLJVRdw+IcH2WHRSYbPG9cgYLvFWtGzaBF0prNm43dFanFH3t1/VyrxEopXUX6cXHRdrZRbGykuufhsUxnvWcUSj2bn84= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43DLxjRW009753 for ; Sat, 13 Apr 2024 23:07:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=zovT1zyoWuLph+zW3dfs5EgAspOV8zqK3OUQ1DVzGd8=; b=MOm5xKywWbCn0bzCSM94C34zf+gzKWhWscgDVI3DOXBx3JMj71C86F1m5XAv6Wo+5MDZ 2H0WJdx2R6+W7vlqTPhiamAem9Pgkku9x4oURe2moRJHQMQSDBe/AFiIImFfzfjoynL8 B/W3w8cQIAKOJ4IMBOKkZf5h2gGsHhFX7Pk7Jjblux1z0NksVgBvIdKYjuUQKilA3ef6 mP4L+tUwKsFyuHR1DjSEDR9KyNI6Qo86i0fAbZdXXAwX/caIuxmfURQVPztY31qA0wFi //ea7iseHgJ2MQaFeIm/Z33TXQ4yx0ci92paA24qg1tZEfYUhrFo9O7fIli7vq+WtGbQ +A== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xfyrag7n2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 13 Apr 2024 23:07:19 +0000 Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 43DN7IPW000814 for ; Sat, 13 Apr 2024 23:07:19 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xfyrag7n1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 13 Apr 2024 23:07:18 +0000 Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 43DKBu3F021496; Sat, 13 Apr 2024 23:07:18 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([172.16.1.72]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3xbjxmhumj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 13 Apr 2024 23:07:18 +0000 Received: from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com [10.39.53.233]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 43DN7Eu016908922 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 13 Apr 2024 23:07:16 GMT Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CDCFD5806A; Sat, 13 Apr 2024 23:07:14 +0000 (GMT) Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 70C9558089; Sat, 13 Apr 2024 23:07:14 +0000 (GMT) Received: from [9.61.128.5] (unknown [9.61.128.5]) by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTP; Sat, 13 Apr 2024 23:07:14 +0000 (GMT) Message-ID: <52248432-2d0f-4249-a003-ce9b66d859e2@linux.ibm.com> Date: Sat, 13 Apr 2024 18:07:13 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] powerpc: Fix ld.so address determination for PCREL mode (bug 31640) To: Florian Weimer , libc-alpha@sourceware.org References: <87edb92vsi.fsf@oldenburg.str.redhat.com> Content-Language: en-US From: Peter Bergner In-Reply-To: <87edb92vsi.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: DnWqVvC6lQ_b1jMStYzYVbJyymJ8nX5_ X-Proofpoint-ORIG-GUID: -F21sPA6kmS-uCsk9QGyiZz0GOjcqYN2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-13_11,2024-04-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxlogscore=999 impostorscore=0 mlxscore=0 suspectscore=0 spamscore=0 priorityscore=1501 clxscore=1015 adultscore=0 lowpriorityscore=0 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404130173 X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/13/24 9:15 AM, Florian Weimer wrote: > This seems to have stopped working with some GCC 14 versions, > which clobber r2. With other compilers, the kernel-provided > r2 value is still available at this point. With PCREL, r2 is just another volatile/caller saved register. That said, it wasn't until GCC commit 1bbb169fe6f9 where we actually started using it. Thanks for finding and fixing this! LGTM Reviewed-by: Peter Bergner Peter